extensions/extensions.gyp - Issue 566863004: Enabling webview in app_shell.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/extensions.gyp

Issue 566863004: Enabling webview in app_shell. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: gn Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: extensions/extensions.gyp

diff --git a/extensions/extensions.gyp b/extensions/extensions.gyp

index bee4c12d59c00927c75e553ba5e889cdaa838d1a..4e7687fb15d2e430d3ef357943913565c3bd3217 100644

--- a/extensions/extensions.gyp

+++ b/extensions/extensions.gyp

@@ -992,6 +992,7 @@

# from generated_resources_en-US.pak. http://crbug.com/397250

'<(SHARED_INTERMEDIATE_DIR)/chrome/generated_resources_en-US.pak',

'<(SHARED_INTERMEDIATE_DIR)/chrome/renderer_resources_100_percent.pak',

+ '<(SHARED_INTERMEDIATE_DIR)/content/app/strings/content_strings_en-US.pak',

James Cook 2014/09/12 20:11:07 I don't see any new references to string resources

lfg 2014/09/12 20:16:25 The string that was missing was IDS_FORM_SUBMIT_LA

'<(SHARED_INTERMEDIATE_DIR)/content/content_resources.pak',

'<(SHARED_INTERMEDIATE_DIR)/content/shell_resources.pak',

'<(SHARED_INTERMEDIATE_DIR)/extensions/extensions_renderer_resources.pak',