Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(257)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 56673002: Mirror removals. (Closed)

Created:
7 years, 1 month ago by rmacnak
Modified:
7 years, 1 month ago
Reviewers:
gbracha, ahe, zarah
CC:
reviews_dartlang.org, vm-dev_dartlang.org
Visibility:
Public.

Description

Mirror removals. BUG=

Patch Set 1 #

Patch Set 2 : #

Patch Set 3 : #

Patch Set 4 : #

Patch Set 5 : also update things in /pkg #

Total comments: 6

Patch Set 6 : #

Patch Set 7 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+477 lines, -483 lines) Patch
M pkg/observe/lib/src/observable.dart View 1 2 3 4 1 chunk +5 lines, -2 lines 0 comments Download
M pkg/serialization/lib/src/serialization_rule.dart View 1 2 3 4 1 chunk +9 lines, -4 lines 0 comments Download
M pkg/unittest/lib/mirror_matchers.dart View 1 2 3 4 1 chunk +7 lines, -1 line 0 comments Download
M runtime/lib/mirrors_impl.dart View 1 2 3 4 9 chunks +39 lines, -137 lines 0 comments Download
M runtime/tests/vm/dart/mirrored_compilation_error_test.dart View 1 chunk +3 lines, -3 lines 0 comments Download
M sdk/lib/_internal/lib/js_mirrors.dart View 1 2 3 4 5 6 22 chunks +49 lines, -49 lines 0 comments Download
M tests/compiler/dart2js/message_kind_test.dart View 1 2 1 chunk +3 lines, -1 line 0 comments Download
M tests/lib/lib.status View 1 2 3 4 5 6 4 chunks +5 lines, -45 lines 0 comments Download
M tests/lib/mirrors/basic_types_in_dart_core_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/constructor_kinds_test.dart View 3 chunks +10 lines, -9 lines 0 comments Download
M tests/lib/mirrors/constructors_test.dart View 2 chunks +12 lines, -4 lines 0 comments Download
M tests/lib/mirrors/equality_test.dart View 1 2 2 chunks +22 lines, -22 lines 0 comments Download
M tests/lib/mirrors/fake_function_with_call_test.dart View 2 chunks +11 lines, -2 lines 0 comments Download
M tests/lib/mirrors/generic_function_typedef_test.dart View 1 2 1 chunk +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/generic_type_mirror_test.dart View 1 2 3 4 5 2 chunks +14 lines, -14 lines 0 comments Download
M tests/lib/mirrors/generics_substitution_test.dart View 1 2 3 4 1 chunk +6 lines, -3 lines 0 comments Download
M tests/lib/mirrors/generics_test.dart View 1 2 3 4 5 1 chunk +4 lines, -5 lines 0 comments Download
M tests/lib/mirrors/hierarchy_invariants_test.dart View 1 2 3 4 5 2 chunks +4 lines, -4 lines 0 comments Download
M tests/lib/mirrors/immutable_collections_test.dart View 2 chunks +12 lines, -24 lines 0 comments Download
M tests/lib/mirrors/inherit_field_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/initializing_formals_test.dart View 1 2 10 chunks +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/intercepted_class_test.dart View 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/lazy_static_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/libraries_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/library_metadata2_test.dart View 1 2 1 chunk +2 lines, -2 lines 0 comments Download
M tests/lib/mirrors/metadata_constructed_constant_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/metadata_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/lib/mirrors/method_mirror_properties_test.dart View 1 chunk +12 lines, -12 lines 0 comments Download
M tests/lib/mirrors/method_mirror_returntype_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M tests/lib/mirrors/method_mirror_source_test.dart View 1 chunk +10 lines, -10 lines 0 comments Download
M tests/lib/mirrors/mirrors_test.dart View 2 chunks +6 lines, -6 lines 0 comments Download
M tests/lib/mirrors/mixin_application_test.dart View 14 chunks +43 lines, -26 lines 0 comments Download
M tests/lib/mirrors/mixin_members_test.dart View 1 chunk +13 lines, -4 lines 0 comments Download
M tests/lib/mirrors/operator_test.dart View 1 chunk +2 lines, -1 line 0 comments Download
M tests/lib/mirrors/parameter_metadata_test.dart View 1 2 1 chunk +13 lines, -13 lines 0 comments Download
M tests/lib/mirrors/parameter_test.dart View 4 chunks +11 lines, -8 lines 0 comments Download
M tests/lib/mirrors/private_symbol_test.dart View 2 chunks +7 lines, -7 lines 0 comments Download
M tests/lib/mirrors/reflect_model_test.dart View 4 chunks +44 lines, -12 lines 0 comments Download
M tests/lib/mirrors/reflect_runtime_type_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/lib/mirrors/reflect_uninstantiated_class_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/lib/mirrors/regress_14304_test.dart View 1 chunk +1 line, -1 line 0 comments Download
A tests/lib/mirrors/removed_api_test.dart View 1 chunk +37 lines, -0 lines 0 comments Download
M tests/lib/mirrors/return_type_test.dart View 2 chunks +9 lines, -3 lines 0 comments Download
M tests/lib/mirrors/static_test.dart View 1 chunk +5 lines, -5 lines 0 comments Download
M tests/lib/mirrors/to_string_test.dart View 1 chunk +3 lines, -2 lines 0 comments Download
M tests/lib/mirrors/type_variable_owner_test.dart View 1 chunk +1 line, -1 line 0 comments Download

Messages

Total messages: 6 (0 generated)
rmacnak
14 non-mirrors tests broken 1 mirrors test broken for dart2js WIP
7 years, 1 month ago (2013-11-02 00:44:27 UTC) #1
rmacnak
Fixed uses in packages. https://codereview.chromium.org/56673002/diff/110001/sdk/lib/_internal/lib/js_mirrors.dart File sdk/lib/_internal/lib/js_mirrors.dart (right): https://codereview.chromium.org/56673002/diff/110001/sdk/lib/_internal/lib/js_mirrors.dart#newcode967 sdk/lib/_internal/lib/js_mirrors.dart:967: Map<Symbol, DeclarationMirror> get declarations => ...
7 years, 1 month ago (2013-11-04 18:19:01 UTC) #2
gbracha
tests lgtm with minor comments https://codereview.chromium.org/56673002/diff/110001/tests/lib/mirrors/generic_type_mirror_test.dart File tests/lib/mirrors/generic_type_mirror_test.dart (right): https://codereview.chromium.org/56673002/diff/110001/tests/lib/mirrors/generic_type_mirror_test.dart#newcode32 tests/lib/mirrors/generic_type_mirror_test.dart:32: MethodMirror p = foo.declarations[const ...
7 years, 1 month ago (2013-11-04 23:41:38 UTC) #3
rmacnak
https://codereview.chromium.org/56673002/diff/110001/tests/lib/mirrors/generic_type_mirror_test.dart File tests/lib/mirrors/generic_type_mirror_test.dart (right): https://codereview.chromium.org/56673002/diff/110001/tests/lib/mirrors/generic_type_mirror_test.dart#newcode32 tests/lib/mirrors/generic_type_mirror_test.dart:32: MethodMirror p = foo.declarations[const Symbol('p')]; On 2013/11/04 23:41:38, gbracha ...
7 years, 1 month ago (2013-11-06 01:28:35 UTC) #4
gbracha
lgtm again
7 years, 1 month ago (2013-11-06 01:48:43 UTC) #5
rmacnak
7 years, 1 month ago (2013-11-06 19:05:36 UTC) #6 
Sync'd with "Add 'declarations' getter in JsTypeBoundClassMirror."

Powered by Google App Engine
This is Rietveld 408576698