Compile chrome://settings, part 8: the final battle

chrome/browser/resources/options/browser_options.js

Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 56c473175728dc76565f97c04b68e9fe7df02f44..0a4848ecd3037f4bf471e7aeee2745a60f02c515 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -12,7 +12,6 @@ cr.exportPath('options');
  *            setupCompleted: (boolean|undefined),
  *            setupInProgress: (boolean|undefined),
  *            signedIn: (boolean|undefined),
- *            signinAllowed: (boolean|undefined),
  *            signinAllowed: boolean,
  *            signoutAllowed: (boolean|undefined),
  *            statusText: (string|undefined),
@@ -21,6 +20,12 @@ cr.exportPath('options');
  */
 options.SyncStatus;
 
+/**
+ * @typedef {{id: string,
+ *            name: string}}

[Dan Beam, 2014/09/16 01:19:10]

nit: /** @typedef {{id: string, name: string}} */

[Vitaly Pavlenko, 2014/09/16 03:36:55]

Done.

+ */
+options.ExtensionData;
+
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var Page = cr.ui.pageManager.Page;
@@ -1752,8 +1757,12 @@ cr.define('options', function() {
     /**
      * Toggles the warning boxes that show which extension is controlling
      * various settings of Chrome.
-     * @param {object} details A dictionary of ID+name pairs for each of the
-     *     settings controlled by an extension.
+     * @param {{searchEngine: options.ExtensionData,
+     *          homePage: options.ExtensionData,
+     *          startUpPage: options.ExtensionData,
+     *          newTabPage: options.ExtensionData,
+     *          proxy: options.ExtensionData}} details A dictionary of ID+name
+     *     pairs for each of the settings controlled by an extension.
      * @private
      */
     toggleExtensionIndicators_: function(details) {