Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2658)

Unified Diff: chrome/browser/resources/options/browser_options.js

Issue 566063002: Compile chrome://settings, part 8: the final battle (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_6
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/browser_options.js
diff --git a/chrome/browser/resources/options/browser_options.js b/chrome/browser/resources/options/browser_options.js
index 56c473175728dc76565f97c04b68e9fe7df02f44..2dc40f06d6060e8c79226426c7f220e16b04e5c2 100644
--- a/chrome/browser/resources/options/browser_options.js
+++ b/chrome/browser/resources/options/browser_options.js
@@ -12,7 +12,6 @@ cr.exportPath('options');
* setupCompleted: (boolean|undefined),
* setupInProgress: (boolean|undefined),
* signedIn: (boolean|undefined),
- * signinAllowed: (boolean|undefined),
* signinAllowed: boolean,
* signoutAllowed: (boolean|undefined),
* statusText: (string|undefined),
@@ -1752,8 +1751,12 @@ cr.define('options', function() {
/**
* Toggles the warning boxes that show which extension is controlling
* various settings of Chrome.
- * @param {object} details A dictionary of ID+name pairs for each of the
- * settings controlled by an extension.
+ * @param {{searchEngine: {id: string, name: string},
+ * homePage: {id: string, name: string},
+ * startUpPage: {id: string, name: string},
+ * newTabPage: {id: string, name: string},
+ * proxy: {id: string, name: string}}} details A dictionary of
Dan Beam 2014/09/12 23:36:12 @typedef for {id: string, name: string}?
Vitaly Pavlenko 2014/09/13 00:02:36 Done.
+ * ID+name pairs for each of the settings controlled by an extension.
* @private
*/
toggleExtensionIndicators_: function(details) {

Powered by Google App Engine
This is Rietveld 408576698