Compile chrome://settings, part 8: the final battle

chrome/browser/resources/options/chromeos/internet_detail.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // require: onc_data.js
 
 // NOTE(stevenjb): This code is in the process of being converted to be
 // compatible with the networkingPrivate extension API:
 // * The network property dictionaries are being converted to use ONC values.
 // * chrome.send calls will be replaced with an API object that simulates the
@@ skipping 96 matching lines @@
    * @param {string} message The message to send to chrome.
    * @param {HTMLInputElement} checkbox The checkbox storing the value to send.
    */
   function sendCheckedIfEnabled(path, message, checkbox) {
     if (!checkbox.hidden && !checkbox.disabled)
       chrome.send(message, [path, checkbox.checked ? 'true' : 'false']);
   }
 
   /**
    * Returns the netmask as a string for a given prefix length.
-   * @param {string} prefixLength The ONC routing prefix length.
+   * @param {number} prefixLength The ONC routing prefix length.
    * @return {string} The corresponding netmask.
    */
   function prefixLengthToNetmask(prefixLength) {
     // Return the empty string for invalid inputs.
     if (prefixLength < 0 || prefixLength > 32)
       return '';
     var netmask = '';
     for (var i = 0; i < 4; ++i) {
       var remainder = 8;
       if (prefixLength >= 8) {
@@ skipping 1049 matching lines @@
     // Override the "automatic" values with the real saved DHCP values,
     // if they are set.
     var savedNameServersString;
     var savedIpAddress = onc.getActiveValue('SavedIPConfig.IPAddress');
     if (savedIpAddress != undefined) {
       inetAddress.automatic = savedIpAddress;
       inetAddress.value = savedIpAddress;
     }
     var savedPrefix = onc.getActiveValue('SavedIPConfig.RoutingPrefix');
     if (savedPrefix != undefined) {
-      var savedNetmask = prefixLengthToNetmask(savedPrefix);
+      assert(typeof savedPrefix == 'number');
+      var savedNetmask = prefixLengthToNetmask(
+          /** @type {number} */(savedPrefix));
       inetNetmask.automatic = savedNetmask;
       inetNetmask.value = savedNetmask;
     }
     var savedGateway = onc.getActiveValue('SavedIPConfig.Gateway');
     if (savedGateway != undefined) {
       inetGateway.automatic = savedGateway;
       inetGateway.value = savedGateway;
     }
     var savedNameServers = onc.getActiveValue('SavedIPConfig.NameServers');
     if (savedNameServers) {
       savedNameServers = savedNameServers.sort();
       savedNameServersString = savedNameServers.join(',');
     }
 
     var ipAutoConfig = 'automatic';
 
     var staticNameServersString;
     var staticIpAddress = onc.getActiveValue('StaticIPConfig.IPAddress');
     if (staticIpAddress != undefined) {
       ipAutoConfig = 'user';
       inetAddress.user = staticIpAddress;
       inetAddress.value = staticIpAddress;
     }
     var staticPrefix = onc.getActiveValue('StaticIPConfig.RoutingPrefix');
     if (staticPrefix != undefined) {
-      var staticNetmask = prefixLengthToNetmask(staticPrefix);
+      assert(typeof staticPrefix == 'number');
+      var staticNetmask = prefixLengthToNetmask(
+          /** @type {number} */(staticPrefix));
       inetNetmask.user = staticNetmask;
       inetNetmask.value = staticNetmask;
     }
     var staticGateway = onc.getActiveValue('StaticIPConfig.Gateway');
     if (staticGateway != undefined) {
       inetGateway.user = staticGateway;
       inetGateway.value = staticGateway;
     }
     var staticNameServers = onc.getActiveValue('StaticIPConfig.NameServers');
     if (staticNameServers) {
@@ skipping 233 matching lines @@
 
     // Don't show page name in address bar and in history to prevent people
     // navigate here by hand and solve issue with page session restore.
     PageManager.showPageByName('detailsInternetPage', false);
   };
 
   return {
     DetailsInternetPage: DetailsInternetPage
   };
 });