Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(8)

Unified Diff: chrome/test/data/extensions/platform_apps/web_view/shim/main.js

Issue 564153003: Browser Plugin: Don't crash browser when reloading crashed webview (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Update BrowserPluginGuest state even if NULL Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/test/data/extensions/platform_apps/web_view/shim/main.js
diff --git a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
index b0487a901afadc51443010597be84eefec461c4a..d6688bcafba088092ff4a2f31e0060587f7f3785 100644
--- a/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
+++ b/chrome/test/data/extensions/platform_apps/web_view/shim/main.js
@@ -1367,6 +1367,40 @@ function testReload() {
document.body.appendChild(webview);
}
+// This test verifies that the reload method on webview functions as expected.
+function testReloadAfterTerminate() {
+ var triggerNavUrl = 'data:text/html,trigger navigation';
+ var webview = document.createElement('webview');
+
+ var step = 1;
+ webview.addEventListener('loadstop', function(e) {
+ switch (step) {
+ case 1:
+ webview.terminate();
+ break;
+ case 2:
+ setTimeout(function() { embedder.test.succeed(); }, 0);
+ break;
+ default:
+ window.console.log('Unexpected loadstop event, step = ' + step);
+ embedder.test.fail();
+ break;
+ }
+ ++step;
+ });
+
+ webview.addEventListener('exit', function(e) {
+ // Trigger a focus state change of the guest to test for
+ // http://crbug.com/413874.
+ webview.blur();
+ webview.focus();
+ setTimeout(function() { webview.reload(); }, 0);
+ });
+
+ webview.src = triggerNavUrl;
+ document.body.appendChild(webview);
+}
+
// This test verifies that a <webview> is torn down gracefully when removed from
// the DOM on exit.
@@ -1834,6 +1868,7 @@ embedder.test.testList = {
'testNavigateAfterResize': testNavigateAfterResize,
'testNavigationToExternalProtocol': testNavigationToExternalProtocol,
'testReload': testReload,
+ 'testReloadAfterTerminate': testReloadAfterTerminate,
'testRemoveWebviewOnExit': testRemoveWebviewOnExit,
'testRemoveWebviewAfterNavigation': testRemoveWebviewAfterNavigation,
'testResizeWebviewResizesContent': testResizeWebviewResizesContent,

Powered by Google App Engine
This is Rietveld 408576698