GN: Fix library flag generation logic

third_party/cython/python_flags.py

Index: third_party/cython/python_flags.py
diff --git a/third_party/cython/python_flags.py b/third_party/cython/python_flags.py
index 542b4770c1517cdd1828b7489166fad27bbb685b..a9a32287207d6b73f0cd103a2f6b694492d45baf 100644
--- a/third_party/cython/python_flags.py
+++ b/third_party/cython/python_flags.py
@@ -34,9 +34,10 @@ def main():
   result = []
   if opts.libraries:
     libraries = b.get_libraries(ext)
-    if sys.platform in ['darwin', 'linux2']:
-      # In case of darwin and linux prefix all libraries (if there is any)
-      # so it can be used as a compiler argument.
+    if not opts.gn and sys.platform in ['darwin', 'linux2']:
+      # In case of GYP output for darwin and linux prefix all
+      # libraries (if there are any) so the result can be used as a
+      # compiler argument. GN handles platform-appropriate prefixing itself.
       libraries = ['-l%s' % library for library in libraries]
       if sys.platform == 'darwin':
         libraries.append('-lpython%s' % sys.version[:3])

[qsr, 2014/09/12 08:38:13]

You need to add this even for gn. At this point, my guess is that you should
write it this way:

libraries = b.get_libraries(ext)
if sys.platform == 'darwin':
  libraries.append('python%s' % sys.version[:3])
if not opts.gn and sys.platform in ['darwin', 'linux2']:
  libraries = ['-l%s' % library for library in libraries]

[Chris Masone, 2014/09/12 15:56:40]

Done.