GN: Fix library flag generation logic

GN: Fix library flag generation logic

GN handles adding platform-appropriate prefixes to library
entries. As such, doing it here leads to stuff like '-l-lpython'
winding up in generated build files.

BUG=388412
TEST=use GN to generate build files for something that depends on cython
R=qsr@chromium.org

Committed: https://crrev.com/8b12d93bd13c94fbf83970751dc486d62d91ca95
Cr-Commit-Position: refs/heads/master@{#294606}

[Chris Masone, 2014-09-11 20:50:34]

PTAL

[qsr, 2014-09-12 08:38:14]

https://chromiumcodereview.appspot.com/563903002/diff/1/third_party/cython/py...
File third_party/cython/python_flags.py (right):

https://chromiumcodereview.appspot.com/563903002/diff/1/third_party/cython/py...
third_party/cython/python_flags.py:43: libraries.append('-lpython%s' %
sys.version[:3])
You need to add this even for gn. At this point, my guess is that you should
write it this way:

libraries = b.get_libraries(ext)
if sys.platform == 'darwin':
  libraries.append('python%s' % sys.version[:3])
if not opts.gn and sys.platform in ['darwin', 'linux2']:
  libraries = ['-l%s' % library for library in libraries]

[qsr, 2014-09-12 08:38:26]

On 2014/09/12 08:38:14, qsr wrote:
>
https://chromiumcodereview.appspot.com/563903002/diff/1/third_party/cython/py...
> File third_party/cython/python_flags.py (right):
> 
>
https://chromiumcodereview.appspot.com/563903002/diff/1/third_party/cython/py...
> third_party/cython/python_flags.py:43: libraries.append('-lpython%s' %
> sys.version[:3])
> You need to add this even for gn. At this point, my guess is that you should
> write it this way:
> 
> libraries = b.get_libraries(ext)
> if sys.platform == 'darwin':
>   libraries.append('python%s' % sys.version[:3])
> if not opts.gn and sys.platform in ['darwin', 'linux2']:
>   libraries = ['-l%s' % library for library in libraries]

LGTM with this change.

[Chris Masone, 2014-09-12 15:56:40]

https://codereview.chromium.org/563903002/diff/1/third_party/cython/python_fl...
File third_party/cython/python_flags.py (right):

https://codereview.chromium.org/563903002/diff/1/third_party/cython/python_fl...
third_party/cython/python_flags.py:43: libraries.append('-lpython%s' %
sys.version[:3])
On 2014/09/12 08:38:13, qsr wrote:
> You need to add this even for gn. At this point, my guess is that you should
> write it this way:
> 
> libraries = b.get_libraries(ext)
> if sys.platform == 'darwin':
>   libraries.append('python%s' % sys.version[:3])
> if not opts.gn and sys.platform in ['darwin', 'linux2']:
>   libraries = ['-l%s' % library for library in libraries]

Done.

[Chris Masone, 2014-09-12 16:00:50]

The CQ bit was checked by cmasone@chromium.org

[commit-bot: I haz the power, 2014-09-12 16:01:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/563903002/20001

[commit-bot: I haz the power, 2014-09-12 17:02:21]

Committed patchset #2 (id:20001) as 94e54e3ad5286270905942f5dd107ec980175dc5

[commit-bot: I haz the power, 2014-09-12 17:09:20]

Patchset 2 (id:??) landed as
https://crrev.com/8b12d93bd13c94fbf83970751dc486d62d91ca95
Cr-Commit-Position: refs/heads/master@{#294606}