Adding transport to Cast/test

media/cast/test/transport/transport.h

+// Copyright 2013 The Chromium Authors. All rights reserved.
+// Use of this source code is governed by a BSD-style license that can be
+// found in the LICENSE file.
+
+#ifndef MEDIA_CAST_TEST_TRANSPORT_TRANSPORT_H_
+#define MEDIA_CAST_TEST_TRANSPORT_TRANSPORT_H_
+
+#include "base/memory/scoped_ptr.h"
+#include "media/cast/cast_config.h"
+#include "media/cast/cast_environment.h"
+#include "net/udp/udp_server_socket.h"
+#include "net/udp/udp_socket.h"
+
+

[Alpha Left Google, 2013/11/01 23:23:19]

nit: remove this extra space.

+namespace media {
+namespace cast {
+namespace test {
+
+class LocalUdpTransportData;
+
+// Helper class for Cast test applications.
+class Transport {
+ public:
+  Transport(scoped_refptr<CastEnvironment> cast_environment);
+  ~Transport();
+
+  // Specifies the ports and IP address to receive packets on.

[Alpha Left Google, 2013/11/01 23:23:19]

nit: s/ports/port/.

+  // Will start listening immediately.
+  void SetLocalReceiver(PacketReceiver* packet_receiver,
+                        std::string ip_address,
+                        int port);
+
+  // Specifies the destination port and IP address.
+  void SetSendDestination(std::string ip_address, int port);
+
+  PacketSender* packet_sender() {return packet_sender_.get();}

[Alpha Left Google, 2013/11/01 23:23:19]

nit: { return packet_sender_.get(); }

Give a space between {}.

+
+  void SetSendSidePacketLoss(int percentage);
+
+  void StopReceiving();
+
+ private:
+  scoped_ptr<net::DatagramServerSocket> udp_socket_;
+  scoped_ptr<PacketSender> packet_sender_;

[Alpha Left Google, 2013/11/01 23:23:19]

Why not just use scoped_ptr<LocalPacketSender>? You can forward declare it at
the top.

+  scoped_ptr<LocalUdpTransportData> local_udp_transport_data_;
+
+  DISALLOW_COPY_AND_ASSIGN(Transport);
+};
+
+}  // namespace test
+}  // namespace cast
+}  // namespace media
+
+#endif  // MEDIA_CAST_TEST_TRANSPORT_TRANSPORT_H_