Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(298)

Side by Side Diff: extensions/browser/api/extensions_api_client.h

Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_ 5 #ifndef EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_
6 #define EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_ 6 #define EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_
7 7
8 #include <map> 8 #include <map>
9 9
10 #include "base/memory/ref_counted.h" 10 #include "base/memory/ref_counted.h"
11 #include "base/memory/scoped_ptr.h" 11 #include "base/memory/scoped_ptr.h"
12 #include "extensions/browser/api/declarative/rules_registry.h" 12 #include "extensions/browser/api/declarative/rules_registry.h"
13 #include "extensions/browser/api/storage/settings_namespace.h" 13 #include "extensions/browser/api/storage/settings_namespace.h"
14 14
15 class GURL; 15 class GURL;
16 16
17 template <class T> 17 template <class T>
18 class ObserverListThreadSafe; 18 class ObserverListThreadSafe;
19 19
20 namespace content { 20 namespace content {
21 class BrowserContext; 21 class BrowserContext;
22 } 22 }
23 23
24 namespace extensions { 24 namespace extensions {
25 25
26 class AppViewGuestDelegate; 26 class AppViewGuestDelegate;
27 class ExtensionOptionsGuest;
27 class ExtensionOptionsGuestDelegate; 28 class ExtensionOptionsGuestDelegate;
28 class MimeHandlerViewGuest; 29 class MimeHandlerViewGuest;
29 class MimeHandlerViewGuestDelegate; 30 class MimeHandlerViewGuestDelegate;
30 class WebViewGuest; 31 class WebViewGuest;
31 class WebViewGuestDelegate; 32 class WebViewGuestDelegate;
32 class WebViewPermissionHelper; 33 class WebViewPermissionHelper;
33 class WebViewPermissionHelperDelegate; 34 class WebViewPermissionHelperDelegate;
34 class SettingsObserver; 35 class SettingsObserver;
35 class SettingsStorageFactory; 36 class SettingsStorageFactory;
36 class ValueStoreCache; 37 class ValueStoreCache;
(...skipping 20 matching lines...) Expand all
57 content::BrowserContext* context, 58 content::BrowserContext* context,
58 const scoped_refptr<SettingsStorageFactory>& factory, 59 const scoped_refptr<SettingsStorageFactory>& factory,
59 const scoped_refptr<ObserverListThreadSafe<SettingsObserver> >& observers, 60 const scoped_refptr<ObserverListThreadSafe<SettingsObserver> >& observers,
60 std::map<settings_namespace::Namespace, ValueStoreCache*>* caches); 61 std::map<settings_namespace::Namespace, ValueStoreCache*>* caches);
61 62
62 // Creates the AppViewGuestDelegate. 63 // Creates the AppViewGuestDelegate.
63 virtual AppViewGuestDelegate* CreateAppViewGuestDelegate() const; 64 virtual AppViewGuestDelegate* CreateAppViewGuestDelegate() const;
64 65
65 // Returns a delegate for ExtensionOptionsGuest. The caller owns the returned 66 // Returns a delegate for ExtensionOptionsGuest. The caller owns the returned
66 // ExtensionOptionsGuestDelegate. 67 // ExtensionOptionsGuestDelegate.
67 virtual ExtensionOptionsGuestDelegate* CreateExtensionOptionsGuestDelegate() 68 virtual ExtensionOptionsGuestDelegate* CreateExtensionOptionsGuestDelegate(
68 const; 69 ExtensionOptionsGuest* guest) const;
69 70
70 // Creates a delegate for MimeHandlerViewGuest. 71 // Creates a delegate for MimeHandlerViewGuest.
71 virtual scoped_ptr<MimeHandlerViewGuestDelegate> 72 virtual scoped_ptr<MimeHandlerViewGuestDelegate>
72 CreateMimeHandlerViewGuestDelegate(MimeHandlerViewGuest* guest) const; 73 CreateMimeHandlerViewGuestDelegate(MimeHandlerViewGuest* guest) const;
73 74
74 // Returns a delegate for some of WebViewGuest's behavior. The caller owns the 75 // Returns a delegate for some of WebViewGuest's behavior. The caller owns the
75 // returned WebViewGuestDelegate. 76 // returned WebViewGuestDelegate.
76 virtual WebViewGuestDelegate* CreateWebViewGuestDelegate ( 77 virtual WebViewGuestDelegate* CreateWebViewGuestDelegate (
77 WebViewGuest* web_view_guest) const; 78 WebViewGuest* web_view_guest) const;
78 79
(...skipping 10 matching lines...) Expand all
89 const RulesRegistry::WebViewKey& webview_key, 90 const RulesRegistry::WebViewKey& webview_key,
90 const std::string& event_name); 91 const std::string& event_name);
91 92
92 // NOTE: If this interface gains too many methods (perhaps more than 20) it 93 // NOTE: If this interface gains too many methods (perhaps more than 20) it
93 // should be split into one interface per API. 94 // should be split into one interface per API.
94 }; 95 };
95 96
96 } // namespace extensions 97 } // namespace extensions
97 98
98 #endif // EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_ 99 #endif // EXTENSIONS_BROWSER_API_EXTENSIONS_API_CLIENT_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698