Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(448)

Side by Side Diff: chrome/browser/guest_view/extension_options/chrome_extension_options_guest_delegate.cc

Issue 562353002: Refactor ExtensionOptionsGuestDelegate to have an ExtensionOptionsGuest (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Address comments Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #include "chrome/browser/guest_view/extension_options/chrome_extension_options_g uest_delegate.h" 5 #include "chrome/browser/guest_view/extension_options/chrome_extension_options_g uest_delegate.h"
6 6
7 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h" 7 #include "chrome/browser/extensions/chrome_extension_web_contents_observer.h"
8 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h" 8 #include "chrome/browser/renderer_context_menu/render_view_context_menu.h"
9 #include "chrome/browser/ui/browser.h" 9 #include "chrome/browser/ui/browser.h"
10 #include "chrome/browser/ui/browser_finder.h" 10 #include "chrome/browser/ui/browser_finder.h"
11 #include "components/renderer_context_menu/context_menu_delegate.h" 11 #include "components/renderer_context_menu/context_menu_delegate.h"
12 #include "extensions/browser/guest_view/extension_options/extension_options_gues t.h"
12 13
13 namespace extensions { 14 namespace extensions {
14 15
15 ChromeExtensionOptionsGuestDelegate::ChromeExtensionOptionsGuestDelegate() { 16 ChromeExtensionOptionsGuestDelegate::ChromeExtensionOptionsGuestDelegate(
17 ExtensionOptionsGuest* guest)
18 : ExtensionOptionsGuestDelegate(guest) {
16 } 19 }
17 20
18 ChromeExtensionOptionsGuestDelegate::~ChromeExtensionOptionsGuestDelegate() { 21 ChromeExtensionOptionsGuestDelegate::~ChromeExtensionOptionsGuestDelegate() {
19 } 22 }
20 23
21 void 24 void ChromeExtensionOptionsGuestDelegate::DidInitialize() {
22 ChromeExtensionOptionsGuestDelegate::CreateChromeExtensionWebContentsObserver(
23 content::WebContents* web_contents) {
24 extensions::ChromeExtensionWebContentsObserver::CreateForWebContents( 25 extensions::ChromeExtensionWebContentsObserver::CreateForWebContents(
25 web_contents); 26 extension_options_guest()->web_contents());
26 } 27 }
27 28
28 bool ChromeExtensionOptionsGuestDelegate::HandleContextMenu( 29 bool ChromeExtensionOptionsGuestDelegate::HandleContextMenu(
29 content::WebContents* web_contents,
30 const content::ContextMenuParams& params) { 30 const content::ContextMenuParams& params) {
31 ContextMenuDelegate* menu_delegate = 31 ContextMenuDelegate* menu_delegate = ContextMenuDelegate::FromWebContents(
32 ContextMenuDelegate::FromWebContents(web_contents); 32 extension_options_guest()->web_contents());
33 DCHECK(menu_delegate); 33 DCHECK(menu_delegate);
34 34
35 scoped_ptr<RenderViewContextMenu> menu = 35 scoped_ptr<RenderViewContextMenu> menu = menu_delegate->BuildMenu(
36 menu_delegate->BuildMenu(web_contents, params); 36 extension_options_guest()->web_contents(), params);
37 menu_delegate->ShowMenu(menu.Pass()); 37 menu_delegate->ShowMenu(menu.Pass());
38 return true; 38 return true;
39 } 39 }
40 40
41 content::WebContents* ChromeExtensionOptionsGuestDelegate::OpenURLInNewTab( 41 content::WebContents* ChromeExtensionOptionsGuestDelegate::OpenURLInNewTab(
42 content::WebContents* embedder_web_contents,
43 const content::OpenURLParams& params) { 42 const content::OpenURLParams& params) {
44 Browser* browser = chrome::FindBrowserWithWebContents(embedder_web_contents); 43 Browser* browser = chrome::FindBrowserWithWebContents(
44 extension_options_guest()->embedder_web_contents());
45 return browser->OpenURL(params); 45 return browser->OpenURL(params);
46 } 46 }
47 47
48 } // namespace extensions 48 } // namespace extensions
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698