Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(742)

Side by Side Diff: chrome/browser/ui/views/location_bar/location_icon_view.h

Issue 561883006: Hide location icon bubble on 2nd click. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright (c) 2012 The Chromium Authors. All rights reserved. 1 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_ICON_VIEW_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_ICON_VIEW_H_
6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_ICON_VIEW_H_ 6 #define CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_ICON_VIEW_H_
7 7
8 #include "chrome/browser/ui/views/location_bar/page_info_helper.h" 8 #include "chrome/browser/ui/views/location_bar/page_info_helper.h"
9 #include "ui/views/controls/image_view.h" 9 #include "ui/views/controls/image_view.h"
10 10
(...skipping 18 matching lines...) Expand all
29 // Whether we should show the tooltip for this icon or not. 29 // Whether we should show the tooltip for this icon or not.
30 void ShowTooltip(bool show); 30 void ShowTooltip(bool show);
31 31
32 PageInfoHelper* page_info_helper() { return &page_info_helper_; } 32 PageInfoHelper* page_info_helper() { return &page_info_helper_; }
33 33
34 private: 34 private:
35 // Handles both click and gesture events by delegating to the page info 35 // Handles both click and gesture events by delegating to the page info
36 // helper in the appropriate circumstances. 36 // helper in the appropriate circumstances.
37 void OnClickOrTap(const ui::LocatedEvent& event); 37 void OnClickOrTap(const ui::LocatedEvent& event);
38 38
39 // This is used to check if the location icon bubble was showing during the
40 // mouse pressed event. If this is true then the mouse released event is
41 // ignored to prevent the bubble from reshowing.
Peter Kasting 2014/09/17 20:51:42 Nit: How about this: Set to true when the bubble
Gaja 2014/09/18 02:51:39 Perfect. Thanks!.
42 bool suppress_mouse_released_action_;
43
39 PageInfoHelper page_info_helper_; 44 PageInfoHelper page_info_helper_;
40 45
41 DISALLOW_COPY_AND_ASSIGN(LocationIconView); 46 DISALLOW_COPY_AND_ASSIGN(LocationIconView);
42 }; 47 };
43 48
44 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_ICON_VIEW_H_ 49 #endif // CHROME_BROWSER_UI_VIEWS_LOCATION_BAR_LOCATION_ICON_VIEW_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698