Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2003)

Unified Diff: chrome/browser/resources/options/language_list.js

Issue 559423003: Compile chrome://settings, part 7. 33 errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_5
Patch Set: Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/language_list.js
diff --git a/chrome/browser/resources/options/language_list.js b/chrome/browser/resources/options/language_list.js
index 79f918e83791e3a8e629942d6d66739004320a15..1030a0ac70e449e6cd59f36bf21855a1f61d738e 100644
--- a/chrome/browser/resources/options/language_list.js
+++ b/chrome/browser/resources/options/language_list.js
@@ -14,7 +14,7 @@ cr.define('options', function() {
* Creates a new Language list item.
* @param {Object} languageInfo The information of the language.
* @constructor
- * @extends {options.DeletableItem.ListItem}
+ * @extends {options.DeletableItem}
*/
function LanguageListItem(languageInfo) {
var el = cr.doc.createElement('li');
@@ -29,7 +29,7 @@ cr.define('options', function() {
/**
* The language code of this language.
- * @type {string}
+ * @type {?string}
* @private
*/
languageCode_: null,
@@ -56,7 +56,7 @@ cr.define('options', function() {
* Creates a new language list.
* @param {Object=} opt_propertyBag Optional properties.
* @constructor
- * @extends {cr.ui.List}
+ * @extends {options.DeletableItemList}
*/
var LanguageList = cr.ui.define('list');
@@ -132,8 +132,13 @@ cr.define('options', function() {
this.addEventListener('dragleave', this.handleDragLeave_.bind(this));
},
+ /**
+ * @override
+ * @param {string} languageCode
+ */
createItem: function(languageCode) {
- languageInfo = LanguageList.getLanguageInfoFromLanguageCode(languageCode);
+ var languageInfo =
+ LanguageList.getLanguageInfoFromLanguageCode(languageCode);
return new LanguageListItem(languageInfo);
},
@@ -379,7 +384,7 @@ cr.define('options', function() {
/**
* Loads given language list.
- * @param {Array} languageCodes List of language codes.
+ * @param {!Array} languageCodes List of language codes.
* @private
*/
load_: function(languageCodes) {

Powered by Google App Engine
This is Rietveld 408576698