Compile chrome://settings, part 7. 33 errors left

chrome/browser/resources/options/language_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 // TODO(kochi): Generalize the notification as a component and put it
 // in js/cr/ui/notification.js .
 
 cr.define('options', function() {
   /** @const */ var Page = cr.ui.pageManager.Page;
   /** @const */ var PageManager = cr.ui.pageManager.PageManager;
@@ skipping 315 matching lines @@
         var input = element.querySelector('input');
         input.inputMethodId = inputMethod.id;
         input.imeProvider = inputMethod.extensionName;
         var span = element.querySelector('span');
         span.textContent = inputMethod.displayName;
 
         if (inputMethod.optionsPage) {
           var button = document.createElement('button');
           button.textContent = loadTimeData.getString('configure');
           button.inputMethodId = inputMethod.id;
-          button.onclick = function(inputMethodId, e) {
+          button.onclick = (function(inputMethodId, e) {
             chrome.send('inputMethodOptionsOpen', [inputMethodId]);
-          };
-          button.onclick = button.onclick.bind(this, inputMethod.id);
+          }).bind(this, inputMethod.id);

[Dan Beam, 2014/09/12 03:32:13]

why do you need ()?

[Vitaly Pavlenko, 2014/09/12 19:21:16]

Done.

           element.appendChild(button);
         }
 
         // Listen to user clicks.
         input.addEventListener('click',
                                this.handleCheckboxClick_.bind(this));
         inputMethodList.appendChild(element);
       }
     },
 
@@ skipping 396 matching lines @@
       $('language-options-input-method-none').hidden =
           (languageCode in this.languageCodeToInputMethodIdsMap_);
 
       if (focusInputMethodId == 'add') {
         $('language-options-add-button').focus();
       }
     },
 
     /**
      * Updates the language list in the add language overlay.
-     * @param {string} languageCode Language code (ex. "fr").
      * @private
      */
-    updateLanguageListInAddLanguageOverlay_: function(languageCode) {
+    updateLanguageListInAddLanguageOverlay_: function() {
       // Change the visibility of the language list in the add language
       // overlay. Languages that are already active will become invisible,
       // so that users don't add the same language twice.
       var languageOptionsList = $('language-options-list');
       var languageCodes = languageOptionsList.getLanguageCodes();
       var languageCodeSet = {};
       for (var i = 0; i < languageCodes.length; i++) {
         languageCodeSet[languageCodes[i]] = true;
       }
 
@@ skipping 53 matching lines @@
       else
         this.addBlockedLanguage_(selectedLanguageCode);
     },
 
     /**
      * Handles input method checkbox's click event.
      * @param {Event} e Click event.
      * @private
      */
     handleCheckboxClick_: function(e) {
-      var checkbox = e.target;
+      var checkbox = assertInstanceof(e.target, Element);
 
       // Third party IMEs require additional confirmation prior to enabling due
       // to privacy risk.
       if (/^_ext_ime_/.test(checkbox.inputMethodId) && checkbox.checked) {
         var confirmationCallback = this.handleCheckboxUpdate_.bind(this,
                                                                    checkbox);
         var cancellationCallback = function() {
           checkbox.checked = false;
         };
         ThirdPartyImeConfirmOverlay.showConfirmationDialog({
@@ skipping 66 matching lines @@
     },
 
     /**
      * Handles browse.enable_spellchecking change.
      * @param {Event} e Change event.
      * @private
      */
     updateEnableSpellCheck_: function(e) {
        var value = !$('enable-spell-check').checked;
        $('language-options-spell-check-language-button').disabled = value;
-       if (!cr.IsMac)
+       if (!cr.isMac)
          $('edit-dictionary-button').hidden = value;
      },
 
     /**
      * Handles translateBlockedLanguagesPref change.
      * @param {Event} e Change event.
      * @private
      */
     handleTranslateBlockedLanguagesPrefChange_: function(e) {
       this.translateBlockedLanguages_ = e.value.value;
@@ skipping 233 matching lines @@
           seen[preloadEngines[i]] = true;
         }
       }
       return enabledPreloadEngines;
     },
 
     // TODO(kochi): This is an adapted copy from new_tab.js.
     // If this will go as final UI, refactor this to share the component with
     // new new tab page.
     /**
-     * Shows notification
      * @private
      */
     notificationTimeout_: null,
+
+    /**
+     * Shows notification.
+     * @param {string} text
+     * @param {string} actionText
+     * @param {number=} opt_delay
+     * @private
+     */
     showNotification_: function(text, actionText, opt_delay) {
       var notificationElement = $('notification');
       var actionLink = notificationElement.querySelector('.link-color');
       var delay = opt_delay || 10000;
 
       function show() {
         window.clearTimeout(this.notificationTimeout_);
         notificationElement.classList.add('show');
         document.body.classList.add('notification-shown');
       }
@@ skipping 170 matching lines @@
 
   LanguageOptions.onDictionaryDownloadFailure = function(languageCode) {
     LanguageOptions.getInstance().onDictionaryDownloadFailure_(languageCode);
   };
 
   // Export
   return {
     LanguageOptions: LanguageOptions
   };
 });