Compile chrome://settings, part 7. 33 errors left

chrome/browser/resources/options/content_settings.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   /** @const */ var Page = cr.ui.pageManager.Page;
   /** @const */ var PageManager = cr.ui.pageManager.PageManager;
 
   //////////////////////////////////////////////////////////////////////////////
   // ContentSettings class:
 
   /**
    * Encapsulated handling of content settings page.
    * @constructor
+   * @extends {cr.ui.pageManager.Page}
    */
   function ContentSettings() {
     this.activeNavTab = null;
     Page.call(this, 'content',
               loadTimeData.getString('contentSettingsPageTabTitle'),
               'content-settings-page');
   }
 
   cr.addSingletonGetter(ContentSettings);
 
@@ skipping 94 matching lines @@
       for (var i = 0; i < indicators.length; i++) {
         indicators[i].handlePrefChange(event);
       }
     }
   };
 
   /**
    * Updates the labels and indicators for the Media settings. Those require
    * special handling because they are backed by multiple prefs and can change
    * their scope based on the managed state of the backing prefs.
-   * @param {Object} mediaSettings A dictionary containing the following fields:
-   *     {String} askText The label for the ask radio button.
-   *     {String} blockText The label for the block radio button.
-   *     {Boolean} cameraDisabled Whether to disable the camera dropdown.
-   *     {Boolean} micDisabled Whether to disable the microphone dropdown.
-   *     {Boolean} showBubble Wether to show the managed icon and bubble for the
-   *         media label.
-   *     {String} bubbleText The text to use inside the bubble if it is shown.
+   * @param {{askText: string, blockText: string, cameraDisabled: boolean,
+   *          micDisabled: boolean, showBubble: boolean, bubbleText: string}}
+   *     mediaSettings A dictionary containing the following fields:
+   *     askText The label for the ask radio button.
+   *     blockText The label for the block radio button.
+   *     cameraDisabled Whether to disable the camera dropdown.
+   *     micDisabled Whether to disable the microphone dropdown.
+   *     showBubble Wether to show the managed icon and bubble for the media
+   *                label.
+   *     bubbleText The text to use inside the bubble if it is shown.
    */
   ContentSettings.updateMediaUI = function(mediaSettings) {
     $('media-stream-ask-label').innerHTML =
         loadTimeData.getString(mediaSettings.askText);
     $('media-stream-block-label').innerHTML =
         loadTimeData.getString(mediaSettings.blockText);
 
     if (mediaSettings.micDisabled)
       $('media-select-mic').disabled = true;
     if (mediaSettings.cameraDisabled)
@@ skipping 44 matching lines @@
     }
   };
 
   /**
    * @param {string} type The type of exceptions (e.g. "location") to get.
    * @param {string} mode The mode of the desired exceptions list (e.g. otr).
    * @return {?options.contentSettings.ExceptionsList} The corresponding
    *     exceptions list or null.
    */
   ContentSettings.getExceptionsList = function(type, mode) {
-    return document.querySelector(
+    var exceptionsList = document.querySelector(
         'div[contentType=' + type + '] list[mode=' + mode + ']');
+    if (exceptionsList === null)

[Dan Beam, 2014/09/12 03:32:13]

nit:

return !exceptionsList ? null :
    assertInstanceof(exceptionsList, options.contentSettings.ExceptionsList);

[Vitaly Pavlenko, 2014/09/12 19:21:16]

Done.

+      return null;
+    return assertInstanceof(exceptionsList,
+        options.contentSettings.ExceptionsList);
   };
 
   /**
    * The browser's response to a request to check the validity of a given URL
    * pattern.
    * @param {string} type The content type.
    * @param {string} mode The browser mode.
    * @param {string} pattern The pattern.
    * @param {boolean} valid Whether said pattern is valid in the context of
    *     a content exception setting.
@@ skipping 92 matching lines @@
     var deviceSelect = $('media-select-camera');
     chrome.send('setDefaultCaptureDevice', ['camera', deviceSelect.value]);
   };
 
   // Export
   return {
     ContentSettings: ContentSettings
   };
 
 });