Compile chrome://settings, part 7. 33 errors left

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+cr.exportPath('options');
+
+/**
+ * @typedef {{actionLinkText: (string|undefined),
+ *            hasError: (boolean|undefined),
+ *            hasUnrecoverableError: (boolean|undefined),
+ *            managed: (boolean|undefined),
+ *            setupCompleted: (boolean|undefined),
+ *            setupInProgress: (boolean|undefined),
+ *            signedIn: (boolean|undefined),
+ *            signinAllowed: (boolean|undefined),
+ *            signinAllowed: boolean,
+ *            signoutAllowed: (boolean|undefined),
+ *            statusText: (string|undefined),
+ *            syncSystemEnabled: (boolean|undefined)}}
+ * @see chrome/browser/ui/webui/options/browser_options_handler.cc
+ */
+options.SyncStatus;
+
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
   var HotwordSearchSettingIndicator = options.HotwordSearchSettingIndicator;
   var NetworkPredictionOptions = {
     ALWAYS: 0,
     WIFI_ONLY: 1,
@@ skipping 879 matching lines @@
     updateAdvancedSettingsExpander_: function() {
       var expander = $('advanced-settings-expander');
       if (BrowserOptions.shouldShowSection_($('advanced-settings')))
         expander.textContent = loadTimeData.getString('showAdvancedSettings');
       else
         expander.textContent = loadTimeData.getString('hideAdvancedSettings');
     },
 
     /**
      * Updates the sync section with the given state.
-     * @param {Object} syncData A bunch of data records that describe the status
-     *     of the sync system.
+     * @param {options.SyncStatus} syncData A bunch of data records that
+     *     describe the status of the sync system.
      * @private
      */
     updateSyncState_: function(syncData) {
       if (!syncData.signinAllowed &&
           (!syncData.supervisedUser || !cr.isChromeOS)) {
         $('sync-section').hidden = true;
         this.maybeShowUserSection_();
         return;
       }
 
@@ skipping 19 matching lines @@
       // visible, say, due to a dashboard clear, close the dialog.
       // However, if the user gets signed out as a result of abandoning first
       // time sync setup, do not call closeOverlay as it will redirect the
       // browser to the main settings page and override any in-progress
       // user-initiated navigation. See crbug.com/278030.
       // Note: SyncSetupOverlay.closeOverlay is a no-op if the overlay is
       // already hidden.
       if (this.signedIn_ && !syncData.signedIn && !syncData.setupInProgress)
         SyncSetupOverlay.closeOverlay();
 
-      this.signedIn_ = syncData.signedIn;
+      this.signedIn_ = !!syncData.signedIn;
 
       // Display the "advanced settings" button if we're signed in and sync is
       // not managed/disabled. If the user is signed in, but sync is disabled,
       // this button is used to re-enable sync.
       var customizeSyncButton = $('customize-sync');
       customizeSyncButton.hidden = !this.signedIn_ ||
                                    syncData.managed ||
                                    !syncData.syncSystemEnabled;
 
       // Only modify the customize button's text if the new text is different.
       // Otherwise, it can affect search-highlighting in the settings page.
       // See http://crbug.com/268265.
       var customizeSyncButtonNewText = syncData.setupCompleted ?
           loadTimeData.getString('customizeSync') :
           loadTimeData.getString('syncButtonTextStart');
       if (customizeSyncButton.textContent != customizeSyncButtonNewText)
         customizeSyncButton.textContent = customizeSyncButtonNewText;
 
       // Disable the "sign in" button if we're currently signing in, or if we're
       // already signed in and signout is not allowed.
       var signInButton = $('start-stop-sync');
       signInButton.disabled = syncData.setupInProgress;
-      this.signoutAllowed_ = syncData.signoutAllowed;
+      this.signoutAllowed_ = !!syncData.signoutAllowed;
       if (!syncData.signoutAllowed)
         $('start-stop-sync-indicator').setAttribute('controlled-by', 'policy');
       else
         $('start-stop-sync-indicator').removeAttribute('controlled-by');
 
       // Hide the "sign in" button on Chrome OS, and show it on desktop Chrome
       // (except for supervised users, which can't change their signed-in
       // status).
       signInButton.hidden = cr.isChromeOS || syncData.supervisedUser;
 
@@ skipping 61 matching lines @@
      * @param {boolean} show True if the current profile manages any supervised
      *     users.
      */
     updateManagesSupervisedUsers_: function(show) {
       $('profiles-supervised-dashboard-tip').hidden = !show;
       this.maybeShowUserSection_();
     },
 
     /**
      * Get the start/stop sync button DOM element. Used for testing.
-     * @return {DOMElement} The start/stop sync button.
+     * @return {Element} The start/stop sync button.
      * @private
      */
     getStartStopSyncButton_: function() {
       return $('start-stop-sync');
     },
 
     /**
      * Event listener for the 'show home button' preference. Shows/hides the
      * UI for changing the home page with animation, unless this is the first
      * time this function is called, in which case there is no animation.
@@ skipping 133 matching lines @@
     /**
      * Updates the search engine popup with the given entries.
      * @param {Array} engines List of available search engines.
      * @param {number} defaultValue The value of the current default engine.
      * @param {boolean} defaultManaged Whether the default search provider is
      *     managed. If true, the default search provider can't be changed.
      * @private
      */
     updateSearchEngines_: function(engines, defaultValue, defaultManaged) {
       this.clearSearchEngines_();
-      engineSelect = $('default-search-engine');
+      var engineSelect = $('default-search-engine');
       engineSelect.disabled = defaultManaged;
       if (defaultManaged && defaultValue == -1)
         return;
-      engineCount = engines.length;
+      var engineCount = engines.length;
       var defaultIndex = -1;
       for (var i = 0; i < engineCount; i++) {
         var engine = engines[i];
         var option = new Option(engine.name, engine.index);
         if (defaultValue == option.value)
           defaultIndex = i;
         engineSelect.appendChild(option);
       }
       if (defaultIndex >= 0)
         engineSelect.selectedIndex = defaultIndex;
@@ skipping 85 matching lines @@
           showSingleProfileView || OptionsPage.isSettingsApp();
       $('profiles-delete').textContent = showSingleProfileView ?
           loadTimeData.getString('profilesDeleteSingle') :
           loadTimeData.getString('profilesDelete');
       if (OptionsPage.isSettingsApp())
         $('profiles-app-list-switch').hidden = showSingleProfileView;
     },
 
     /**
      * Adds all |profiles| to the list.
-     * @param {Array.<Object>} profiles An array of profile info objects.
-     *     each object is of the form:
-     *       profileInfo = {
-     *         name: "Profile Name",
-     *         iconURL: "chrome://path/to/icon/image",
-     *         filePath: "/path/to/profile/data/on/disk",
-     *         isCurrentProfile: false,
-     *         isSupervised: false
-     *       };
+     * @param {Array.<{name: string, filePath: string,
+     *     isCurrentProfile: boolean, isSupervised: boolean}>} profiles An array
+     *     of profile info objects.
      * @private
      */
     setProfilesInfo_: function(profiles) {
       this.setProfileViewSingle_(profiles.length);
       // add it to the list, even if the list is hidden so we can access it
       // later.
       $('profiles-list').dataModel = new ArrayDataModel(profiles);
 
       // Received new data. If showing the "manage" overlay, keep it up to
       // date. If showing the "delete" overlay, close it.
@@ skipping 681 matching lines @@
       }
       button.textContent = loadTimeData.getString(strId);
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });