Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(347)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 559423003: Compile chrome://settings, part 7. 33 errors left (Closed)

Created:
6 years, 3 months ago by Vitaly Pavlenko
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, yusukes+watch_chromium.org, yukishiino+watch_chromium.org, tfarina, nona+watch_chromium.org, pam+watch_chromium.org, arv+watch_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@H_options_errors_5
Project:
chromium
Visibility:
Public.

Description

Compile chrome://settings, part 7. 33 errors left R=dbeam@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l Committed: https://crrev.com/7fd4b0ee65105406264e0c62303d33b98bee68fe Cr-Commit-Position: refs/heads/master@{#295637}

Patch Set 1 #

Total comments: 6

Patch Set 2 : fixed comments #

Patch Set 3 : rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+121 lines, -64 lines) Patch
M chrome/browser/resources/options/browser_options.js View 1 2 7 chunks +29 lines, -16 lines 0 comments Download
M chrome/browser/resources/options/browser_options_startup_page_list.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/content_settings.js View 1 2 3 chunks +15 lines, -9 lines 0 comments Download
M chrome/browser/resources/options/content_settings_exceptions_area.js View 1 2 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/cookies_list.js View 7 chunks +14 lines, -8 lines 0 comments Download
M chrome/browser/resources/options/easy_unlock_turn_off_overlay.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/handler_options_list.js View 2 chunks +5 lines, -1 line 0 comments Download
M chrome/browser/resources/options/language_dictionary_overlay.js View 1 chunk +3 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/language_dictionary_overlay_word_list.js View 3 chunks +6 lines, -3 lines 0 comments Download
M chrome/browser/resources/options/language_list.js View 5 chunks +10 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/language_options.js View 1 5 chunks +12 lines, -7 lines 0 comments Download
M chrome/browser/resources/options/manage_profile_overlay.js View 1 2 2 chunks +4 lines, -1 line 0 comments Download
M chrome/browser/resources/options/origin_resources_list.js View 1 chunk +4 lines, -1 line 0 comments Download
M chrome/browser/resources/options/password_manager.js View 3 chunks +9 lines, -5 lines 0 comments Download
M chrome/browser/resources/options/supervised_user_import.js View 1 chunk +1 line, -0 lines 0 comments Download
M chrome/browser/resources/options/website_settings.js View 1 2 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/ui/webui/options/browser_options_handler.cc View 1 2 1 chunk +3 lines, -0 lines 0 comments Download

Messages

Total messages: 7 (1 generated)
Vitaly Pavlenko
6 years, 3 months ago (2014-09-12 02:46:06 UTC) #1
Dan Beam
lgtm w/nits https://chromiumcodereview.appspot.com/559423003/diff/1/chrome/browser/resources/options/content_settings.js File chrome/browser/resources/options/content_settings.js (right): https://chromiumcodereview.appspot.com/559423003/diff/1/chrome/browser/resources/options/content_settings.js#newcode206 chrome/browser/resources/options/content_settings.js:206: if (exceptionsList === null) nit: return !exceptionsList ...
6 years, 3 months ago (2014-09-12 03:32:14 UTC) #2
Vitaly Pavlenko
https://chromiumcodereview.appspot.com/559423003/diff/1/chrome/browser/resources/options/content_settings.js File chrome/browser/resources/options/content_settings.js (right): https://chromiumcodereview.appspot.com/559423003/diff/1/chrome/browser/resources/options/content_settings.js#newcode206 chrome/browser/resources/options/content_settings.js:206: if (exceptionsList === null) On 2014/09/12 03:32:13, Dan Beam ...
6 years, 3 months ago (2014-09-12 19:21:17 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/559423003/40001
6 years, 3 months ago (2014-09-19 00:33:29 UTC) #5
commit-bot: I haz the power
Committed patchset #3 (id:40001) as b64d1c920c980fc0d57c4f40003a810c1356d799
6 years, 3 months ago (2014-09-19 01:33:13 UTC) #6
commit-bot: I haz the power
6 years, 3 months ago (2014-09-19 01:33:47 UTC) #7
Message was sent while issue was closed. 
Patchset 3 (id:??) landed as
https://crrev.com/7fd4b0ee65105406264e0c62303d33b98bee68fe
Cr-Commit-Position: refs/heads/master@{#295637}

Powered by Google App Engine
This is Rietveld 408576698