<webview>: Fix an issue with destroying an opener that has unattached guests.

chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var embedder = {};
 embedder.test = {};
 embedder.baseGuestURL = '';
 embedder.guestURL = '';
 embedder.guestWithLinkURL = '';
 embedder.newWindowURL = '';
@@ skipping 182 matching lines @@
 // Loads a guest which requests a new window.
 function testNewWindowNameTakesPrecedence() {
   var webViewName = 'foo';
   var guestName = 'bar';
   var partitionName = 'foobar';
   var expectedName = guestName;
   testNewWindowName('testNewWindowNameTakesPrecedence',
                     webViewName, guestName, partitionName, expectedName);
 }
 
-function testWebViewNameTakesPrecedence() {
+function testNewWindowWebViewNameTakesPrecedence() {
   var webViewName = 'foo';
   var guestName = '';
   var partitionName = 'persist:foobar';
   var expectedName = webViewName;
-  testNewWindowName('testWebViewNameTakesPrecedence',
+  testNewWindowName('testNewWindowWebViewNameTakesPrecedence',
                     webViewName, guestName, partitionName, expectedName);
 }
 
-function testNoName() {
+function testNewWindowNoName() {
   var webViewName = '';
   var guestName = '';
   var partitionName = '';
   var expectedName = '';
-  testNewWindowName('testNoName',
+  testNewWindowName('testNewWindowNoName',
                     webViewName, guestName, partitionName, expectedName);
 }
 
 // This test exercises the need for queuing events that occur prior to
 // attachment. In this test a new window is opened that initially navigates to
 // about:blank and then subsequently redirects to its final destination. This
 // test responds to loadstop in the new <webview>. Since "about:blank" does not
 // have any external resources, it loads immediately prior to attachment, and
 // the <webview> that is eventually attached never gets a chance to see the
 // event. GuestView solves this problem by queuing events that occur prior to
 // attachment and firing them immediately after attachment.
 function testNewWindowRedirect() {
   var webViewName = 'foo';
   var guestName = '';
   var partitionName = 'persist:foobar';
   var expectedName = webViewName;
   testNewWindowName('testNewWindowRedirect_blank',
                     webViewName, guestName, partitionName, expectedName);
 }
 
+// Tests that we fail gracefully if we try to attach() a <webview> on a
+// newwindow event after the opener has been destroyed.
+function testNewWindowAttachAfterOpenerDestroyed() {
+  var testName = 'testNewWindowAttachAfterOpenerDestroyed';
+  var webview = embedder.setUpGuest_('foobar');
+
+  var onNewWindow = function(e) {
+    embedder.assertCorrectEvent_(e, '');
+
+    // Remove the opener.
+    webview.parentNode.removeChild(webview);
+    // Pass in a timeout so we ensure the newwindow disposal codepath
+    // works properly.
+    //window.setTimeout(function() { embedder.test.succeed(); }, 0);

[Fady Samuel, 2014/09/09 23:01:34]

Delete this line?

[lazyboy, 2014/09/09 23:18:36]

Done.

+    window.setTimeout(function() {
+      // At this point the opener <webview> is gone.
+      // Trying to discard() will fail silencly.

[Fady Samuel, 2014/09/09 23:01:33]

s/discard/attach
s/silencly/silently.

[lazyboy, 2014/09/09 23:18:36]

Done.

+      e.window.attach(document.createElement('webview'));
+      window.setTimeout(function() { embedder.test.succeed(); });
+    }, 0);
+
+    e.preventDefault();
+  };
+  webview.addEventListener('newwindow', onNewWindow);
+
+  // Load a new window with the given name.
+  embedder.setUpNewWindowRequest_(webview, 'guest.html', '', testName);
+}
+
 function testNewWindowClose() {
   var testName = 'testNewWindowClose';
   var webview = embedder.setUpGuest_('foobar');
 
   var onNewWindow = function(e) {
     chrome.test.log('Embedder notified on newwindow');
     embedder.assertCorrectEvent_(e, '');
 
     var newwebview = document.createElement('webview');
     document.querySelector('#webview-tag-container').appendChild(newwebview);
@@ skipping 36 matching lines @@
 
     // Append the <webview> in DOM later.
     window.setTimeout(function() {
       document.querySelector('#webview-tag-container').appendChild(newwebview);
     }, 0);
   };
   webview.addEventListener('newwindow', onNewWindow);
 
   // Load a new window with the given name.
   embedder.setUpNewWindowRequest_(webview, 'guest.html', '', testName);
-};
+}
+
+// Tests that we fail gracefully if we try to discard() a <webview> on a
+// newwindow event after the opener has been destroyed.
+function testNewWindowDiscardAfterOpenerDestroyed() {
+  var testName = 'testNewWindowDiscardAfterOpenerDestroyed';
+  var webview = embedder.setUpGuest_('foobar');
+
+  var onNewWindow = function(e) {
+    embedder.assertCorrectEvent_(e, '');
+
+    // Remove the opener.
+    webview.parentNode.removeChild(webview);
+    // Pass in a timeout so we ensure the newwindow disposal codepath
+    // works properly.
+    //window.setTimeout(function() { embedder.test.succeed(); }, 0);

[Fady Samuel, 2014/09/09 23:01:33]

Remove this line?

[lazyboy, 2014/09/09 23:18:36]

Done.

+    window.setTimeout(function() {
+      // At this point the opener <webview> is gone.
+      // Trying to discard() will fail silencly.

[Fady Samuel, 2014/09/09 23:01:34]

s/silency/silently

+      e.window.discard();
+      window.setTimeout(function() { embedder.test.succeed(); });
+    }, 0);
+
+    e.preventDefault();
+  };
+  webview.addEventListener('newwindow', onNewWindow);
+
+  // Load a new window with the given name.
+  embedder.setUpNewWindowRequest_(webview, 'guest.html', '', testName);
+}
 
 function testNewWindowExecuteScript() {
   var testName = 'testNewWindowExecuteScript';
   var webview = embedder.setUpGuest_('foobar');
 
   var onNewWindow = function(e) {
     chrome.test.log('Embedder notified on newwindow');
     embedder.assertCorrectEvent_(e, '');
 
     var newwebview = document.createElement('webview');
@@ skipping 21 matching lines @@
   webview.addEventListener('loadstop', function(e) {
     webview.focus();
     chrome.test.sendMessage('Loaded');
   });
   webview.addEventListener('newwindow', function(e) {
     embedder.test.succeed();
   });
   webview.src = embedder.guestWithLinkURL;
 }
 
+// Tests that if opener <webview> is gone with unattached guest, we
+// don't see any error.
+// This test also makes sure we destroy the unattached guests properly.
+function testNewWindowOpenerDestroyedWhileUnattached() {
+  var testName = 'testNewWindowOpenerDestroyedBeforeAttach';
+  var webview = embedder.setUpGuest_('foobar');
+
+  var onNewWindow = function(e) {
+    embedder.assertCorrectEvent_(e, '');
+
+    // Remove the opener.
+    webview.parentNode.removeChild(webview);
+    // Pass in a timeout so we ensure the newwindow disposal codepath
+    // works properly.
+    window.setTimeout(function() { embedder.test.succeed(); }, 0);
+
+    e.preventDefault();
+  };
+  webview.addEventListener('newwindow', onNewWindow);
+
+  // Load a new window with the given name.
+  embedder.setUpNewWindowRequest_(webview, 'guest.html', '', testName);
+}
+
 function testNewWindowWebRequest() {
   var testName = 'testNewWindowWebRequest';
   var webview = embedder.setUpGuest_('foobar');
 
   var onNewWindow = function(e) {
     chrome.test.log('Embedder notified on newwindow');
     embedder.assertCorrectEvent_(e, '');
 
     var newwebview = new WebView();
     var calledWebRequestEvent = false;
@@ skipping 138 matching lines @@
       };
     });
   };
   webview.addEventListener('newwindow', onNewWindow);
 
   // Load a new window with the given name.
   embedder.setUpNewWindowRequest_(webview, 'guest.html', '', testName);
 }
 
 embedder.test.testList = {
+  'testNewWindowAttachAfterOpenerDestroyed':
+      testNewWindowAttachAfterOpenerDestroyed,
+  'testNewWindowClose': testNewWindowClose,
+  'testNewWindowDeclarativeWebRequest': testNewWindowDeclarativeWebRequest,
+  'testNewWindowDeferredAttachment': testNewWindowDeferredAttachment,
+  'testNewWindowDiscardAfterOpenerDestroyed':
+      testNewWindowDiscardAfterOpenerDestroyed,
+  'testNewWindowExecuteScript': testNewWindowExecuteScript,
   'testNewWindowNameTakesPrecedence': testNewWindowNameTakesPrecedence,
-  'testWebViewNameTakesPrecedence': testWebViewNameTakesPrecedence,
-  'testNoName': testNoName,
+  'testNewWindowNoName': testNewWindowNoName,
+  'testNewWindowOpenInNewTab': testNewWindowOpenInNewTab,
+  'testNewWindowOpenerDestroyedWhileUnattached':
+      testNewWindowOpenerDestroyedWhileUnattached,
   'testNewWindowRedirect':  testNewWindowRedirect,
-  'testNewWindowClose': testNewWindowClose,
-  'testNewWindowDeferredAttachment': testNewWindowDeferredAttachment,
-  'testNewWindowExecuteScript': testNewWindowExecuteScript,
-  'testNewWindowOpenInNewTab': testNewWindowOpenInNewTab,
-  'testNewWindowDeclarativeWebRequest': testNewWindowDeclarativeWebRequest,
   'testNewWindowWebRequest': testNewWindowWebRequest,
   'testNewWindowWebRequestCloseWindow': testNewWindowWebRequestCloseWindow,
-  'testNewWindowWebRequestRemoveElement': testNewWindowWebRequestRemoveElement
+  'testNewWindowWebRequestRemoveElement': testNewWindowWebRequestRemoveElement,
+  'testNewWindowWebViewNameTakesPrecedence':
+      testNewWindowWebViewNameTakesPrecedence
 };
 
 onload = function() {
   chrome.test.getConfig(function(config) {
     embedder.setUp_(config);
     chrome.test.sendMessage('Launched');
   });
 };