<webview>: Fix an issue with destroying an opener that has unattached guests.

chrome/test/data/extensions/platform_apps/web_view/newwindow/embedder.js

 // Copyright 2013 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 var embedder = {};
 embedder.test = {};
 embedder.baseGuestURL = '';
 embedder.guestURL = '';
 embedder.guestWithLinkURL = '';
 embedder.newWindowURL = '';
@@ skipping 315 matching lines @@
   webview.addEventListener('loadstop', function(e) {
     webview.focus();
     chrome.test.sendMessage('Loaded');
   });
   webview.addEventListener('newwindow', function(e) {
     embedder.test.succeed();
   });
   webview.src = embedder.guestWithLinkURL;
 }
 
+function testNewWindowOpenerDestroyedBeforeAttach() {
+  var testName = 'testNewWindowOpenerDestroyedBeforeAttach';
+  var webview = embedder.setUpGuest_('foobar');
+
+  var onNewWindow = function(e) {
+    embedder.assertCorrectEvent_(e, '');
+
+    // Remove the opener.
+    webview.parentNode.removeChild(webview);
+    // Pass in a timeout so we ensure the newwindow disposal codepath
+    // works properly.
+    window.setTimeout(function() { embedder.test.succeed(); }, 0);

[Fady Samuel, 2014/09/09 21:55:34]

What happens if we try e.window.attach on another webview?

[lazyboy, 2014/09/09 22:52:22]

It would throw the same exception, added guards to attach/discard as well.
Added test cases for e.window.attach() and e.window.discard() calls.

+
+    e.preventDefault();
+  };
+  webview.addEventListener('newwindow', onNewWindow);
+
+  // Load a new window with the given name.
+  embedder.setUpNewWindowRequest_(webview, 'guest.html', '', testName);
+}
+
 function testNewWindowWebRequest() {
   var testName = 'testNewWindowWebRequest';
   var webview = embedder.setUpGuest_('foobar');
 
   var onNewWindow = function(e) {
     chrome.test.log('Embedder notified on newwindow');
     embedder.assertCorrectEvent_(e, '');
 
     var newwebview = new WebView();
     var calledWebRequestEvent = false;
@@ skipping 146 matching lines @@
 
 embedder.test.testList = {
   'testNewWindowNameTakesPrecedence': testNewWindowNameTakesPrecedence,
   'testWebViewNameTakesPrecedence': testWebViewNameTakesPrecedence,
   'testNoName': testNoName,
   'testNewWindowRedirect':  testNewWindowRedirect,
   'testNewWindowClose': testNewWindowClose,
   'testNewWindowDeferredAttachment': testNewWindowDeferredAttachment,
   'testNewWindowExecuteScript': testNewWindowExecuteScript,
   'testNewWindowOpenInNewTab': testNewWindowOpenInNewTab,
+  'testNewWindowOpenerDestroyedBeforeAttach':
+      testNewWindowOpenerDestroyedBeforeAttach,
   'testNewWindowDeclarativeWebRequest': testNewWindowDeclarativeWebRequest,
   'testNewWindowWebRequest': testNewWindowWebRequest,
   'testNewWindowWebRequestCloseWindow': testNewWindowWebRequestCloseWindow,
   'testNewWindowWebRequestRemoveElement': testNewWindowWebRequestRemoveElement
 };
 
 onload = function() {
   chrome.test.getConfig(function(config) {
     embedder.setUp_(config);
     chrome.test.sendMessage('Launched');
   });
 };