third_party/closure_compiler/README.chromium - Issue 557633002: Add public API generation with cr.makePublic() and handle it in compiler pass

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/README.chromium

Issue 557633002: Add public API generation with cr.makePublic() and handle it in compiler pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_3

Patch Set: manually handle exported methods declared in base class Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/browser_options.js ('K') | « chrome/browser/resources/options/supervised_user_list_data.js ('k') | third_party/closure_compiler/runner/runner.jar » ('j') | third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/closure_compiler/README.chromium

diff --git a/third_party/closure_compiler/README.chromium b/third_party/closure_compiler/README.chromium

index 6aef43d52fd818f5f1bfb14c8514338373478852..9bcf4e435566241f473279f7694179d5d912c6cd 100644

--- a/third_party/closure_compiler/README.chromium

+++ b/third_party/closure_compiler/README.chromium

@@ -19,7 +19,7 @@ Local modifications:

- Chrome-specific coding conventions to understand cr.addSingletonGetter().

- third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java

Added pass to handle namespace definition with cr.define(), object chain

- creation with cr.exportPath() and property definition with

- {cr|Object}.defineProperty().

+ creation with cr.exportPath(), property definition with

+ {cr|Object}.defineProperty() and public API generation with cr.makePublic().

See third_party/closure_compiler/runner/how_to_test_compiler_pass.md for

testing instructions on this pass.