Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4016)

Unified Diff: chrome/browser/resources/options/automatic_settings_reset_banner.js

Issue 557633002: Add public API generation with cr.makePublic() and handle it in compiler pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_3
Patch Set: manually handle exported methods declared in base class Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/automatic_settings_reset_banner.js
diff --git a/chrome/browser/resources/options/automatic_settings_reset_banner.js b/chrome/browser/resources/options/automatic_settings_reset_banner.js
index 2a1573eb3f3b14f8b038effde6896c2768dd7047..b32ab84be1682986f37b0aae07a6f63d28e30468 100644
--- a/chrome/browser/resources/options/automatic_settings_reset_banner.js
+++ b/chrome/browser/resources/options/automatic_settings_reset_banner.js
@@ -49,16 +49,25 @@ cr.define('options', function() {
},
};
+ /**
+ * Fake declaration made for Closure Compiler. Actual method definition is
+ * in the base class.
Dan Beam 2014/09/10 19:26:27 private methods should not be shared, make this pr
Vitaly Pavlenko 2014/09/10 20:25:21 Should I make them protected in base class and her
Dan Beam 2014/09/12 00:57:51 yes
Vitaly Pavlenko 2014/09/12 18:38:07 Done.
+ * @private
+ */
+ AutomaticSettingsResetBanner.prototype.show_;
+
+ /**
+ * Fake declaration made for Closure Compiler. Actual method definition is
+ * in the base class.
+ * @private
+ */
+ AutomaticSettingsResetBanner.prototype.dismiss_;
+
// Forward public APIs to private implementations.
- [
+ cr.makePublic(AutomaticSettingsResetBanner, [
'show',
'dismiss',
- ].forEach(function(name) {
- AutomaticSettingsResetBanner[name] = function() {
- var instance = AutomaticSettingsResetBanner.getInstance();
- return instance[name + '_'].apply(instance, arguments);
- };
- });
+ ]);
// Export
return {

Powered by Google App Engine
This is Rietveld 408576698