Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(951)

Unified Diff: chrome/browser/resources/options/settings_banner.js

Issue 557633002: Add public API generation with cr.makePublic() and handle it in compiler pass (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_3
Patch Set: remove fake declarations Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/settings_banner.js
diff --git a/chrome/browser/resources/options/settings_banner.js b/chrome/browser/resources/options/settings_banner.js
index dc96c08b864a10de2ad538e5331c4d8e3f4b4dde..5d030a4a309195e60571112345daaeac22f7d553 100644
--- a/chrome/browser/resources/options/settings_banner.js
+++ b/chrome/browser/resources/options/settings_banner.js
@@ -9,6 +9,7 @@ cr.define('options', function() {
/**
* Base class for banners that appear at the top of the settings page.
+ * @constructor
*/
function SettingsBannerBase() {}
@@ -49,37 +50,13 @@ cr.define('options', function() {
setVisibilibyDomElement_: null,
Dan Beam 2014/09/12 23:43:54 rebase, your code is out of date
Vitaly Pavlenko 2014/09/13 01:22:39 Hopefully, done.
/**
- * Called by the native code to show the banner if needed.
- * @private
- */
- show_: function() {
- if (!this.hadBeenDismissed_) {
- chrome.send('metricsHandler:recordAction', [this.showMetricName_]);
- this.setVisibility_(true);
- }
- },
-
- /**
- * Called when the banner should be closed as a result of something taking
- * place on the WebUI page, i.e. when its close button is pressed, or when
- * the confirmation dialog for the profile settings reset feature is opened.
- * @private
- */
- dismiss_: function() {
- chrome.send(this.dismissNativeCallbackName_);
- this.hadBeenDismissed_ = true;
- this.setVisibility_(false);
- },
-
- /**
* Sets whether or not the reset profile settings banner shall be visible.
* @param {boolean} show Whether or not to show the banner.
- * @private
+ * @protected
*/
- setVisibility_: function(show) {
+ setVisibility: function(show) {
this.setVisibilibyDomElement_.hidden = !show;
},
-
};
// Export

Powered by Google App Engine
This is Rietveld 408576698