Add public API generation with cr.makePublic() and handle it in compiler pass

chrome/browser/resources/options/browser_options.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 cr.define('options', function() {
   var OptionsPage = options.OptionsPage;
   var Page = cr.ui.pageManager.Page;
   var PageManager = cr.ui.pageManager.PageManager;
   var ArrayDataModel = cr.ui.ArrayDataModel;
   var RepeatingButton = cr.ui.RepeatingButton;
   var HotwordSearchSettingIndicator = options.HotwordSearchSettingIndicator;
   var NetworkPredictionOptions = {
     ALWAYS: 0,
     WIFI_ONLY: 1,
     NEVER: 2,
     UNSET: 3,
     DEFAULT: 1
   };
 
-  //
-  // BrowserOptions class
-  // Encapsulated handling of browser options page.
-  //
+  /**
+   * Encapsulated handling of browser options page.
+   * @constructor
+   * @extends {cr.ui.pageManager.Page}
+   */
   function BrowserOptions() {
     Page.call(this, 'settings', loadTimeData.getString('settingsTitle'),
               'settings');
   }
 
   cr.addSingletonGetter(BrowserOptions);
 
   /**
    * @param {HTMLElement} section The section to show or hide.
    * @return {boolean} Whether the section should be shown.
@@ skipping 690 matching lines @@
       if (section.classList.contains('sliding'))
         cr.dispatchSimpleEvent(section, 'webkitTransitionEnd');
 
       this.addTransitionEndListener_(section);
 
       section.hidden = false;
       section.style.height = (showing ? 0 : container.offsetHeight) + 'px';
       section.classList.add('sliding');
 
       // Force a style recalc before starting the animation.
       /** @suppress {uselessCode} */

[Dan Beam, 2014/09/12 23:43:54]

i was wrong, can you change this to suspiciousCode?

[Vitaly Pavlenko, 2014/09/13 01:22:39]

Done.

       section.offsetHeight;
 
       section.style.height = (showing ? container.offsetHeight : 0) + 'px';
     },
 
     /**
      * Shows the given section.
      * @param {HTMLElement} section The section to be shown.
      * @param {HTMLElement} container The container for the section. Must be
      *     inside of |section|.
@@ skipping 659 matching lines @@
 
     /**
      * Propmpts user to confirm deletion of the profile for this browser
      * window.
      * @private
      */
     deleteCurrentProfile_: function() {
       ManageProfileOverlay.showDeleteDialog(this.getCurrentProfile_());
     },
 
+    /**
+     * @param {boolean} enabled
+     */
     setNativeThemeButtonEnabled_: function(enabled) {
       var button = $('themes-native-button');
       if (button)
         button.disabled = !enabled;
     },
 
+    /**
+     * @param {boolean} enabled
+     */
     setThemesResetButtonEnabled_: function(enabled) {
       $('themes-reset').disabled = !enabled;
     },
 
+    /**
+     * @param {boolean} managed
+     */
     setAccountPictureManaged_: function(managed) {
       var picture = $('account-picture');
       if (managed || UIAccountTweaks.loggedInAsGuest()) {
         picture.disabled = true;
         ChangePictureOptions.closeOverlay();
       } else {
         picture.disabled = false;
       }
 
       // Create a synthetic pref change event decorated as
@@ skipping 11 matching lines @@
      * @private
      */
     updateAccountPicture_: function() {
       var picture = $('account-picture');
       if (picture) {
         picture.src = 'chrome://userimage/' + this.username_ + '?id=' +
             Date.now();
       }
     },
 
+    /**
+     * @param {boolean} managed
+     */
     setWallpaperManaged_: function(managed) {
       var button = $('set-wallpaper');
       button.disabled = !!managed;
 
       // Create a synthetic pref change event decorated as
       // CoreOptionsHandler::CreateValueForPref() does.
       var event = new Event('wallpaper');
       if (managed)
         event.value = { controlledBy: 'policy' };
       else
@@ skipping 424 matching lines @@
     /**
      * Handle the 'set date and time' button click.
      * @private
      */
     handleSetTime_: function() {
       chrome.send('showSetTime');
     },
   };
 
   //Forward public APIs to private implementations.
-  [
+  cr.makePublic(BrowserOptions, [
     'addBluetoothDevice',
     'deleteCurrentProfile',
     'enableCertificateButton',
     'enableFactoryResetSection',
     'getCurrentProfile',
     'getStartStopSyncButton',
     'hideBluetoothSettings',
     'notifyInitializationComplete',
     'removeBluetoothDevice',
     'scrollToSection',
@@ skipping 24 matching lines @@
     'showSupervisedUserImportError',
     'showSupervisedUserImportSuccess',
     'showTouchpadControls',
     'toggleExtensionIndicators',
     'updateAccountPicture',
     'updateAutoLaunchState',
     'updateDefaultBrowserState',
     'updateEasyUnlock',
     'updateManagesSupervisedUsers',
     'updateSearchEngines',
-    'updateStartupPages',
     'updateSyncState',
-  ].forEach(function(name) {
-    BrowserOptions[name] = function() {
-      var instance = BrowserOptions.getInstance();
-      return instance[name + '_'].apply(instance, arguments);
-    };
-  });
+  ]);
 
   if (cr.isChromeOS) {
     /**
      * Returns username (canonical email) of the user logged in (ChromeOS only).
      * @return {string} user email.
      */
     // TODO(jhawkins): Investigate the use case for this method.
     BrowserOptions.getLoggedInUsername = function() {
       return BrowserOptions.getInstance().username_;
     };
@@ skipping 34 matching lines @@
       }
       button.textContent = loadTimeData.getString(strId);
     };
   }
 
   // Export
   return {
     BrowserOptions: BrowserOptions
   };
 });