Add delegate to install web_contents helpers for MimeHandlerView.

Add delegate to install web_contents helpers for MimeHandlerView.

These helpers are necessary to make PDF print/save work properly.
However they are not sufficient:
1) PDF SaveAs requires a bit more work to pass in the URL,
  a temporary hack is shown here: http://crrev.com/554893002/
2) PDF Print requires Constrained windows to work with mime-handler view,
  which is being fixed in http://crrev.com/552013005

BUG=411765
Test=Once the changes noted above is done, it should be
possible to print/save PDF from mime-handler-view.
mime-handler-view can be triggered by navigating to a PDF with the
following two chrome flags:
--out-of-process-pdf
--enable-mime-handler-view

Committed: https://crrev.com/9b204d37f67e3f4a07f11ba4e887a028ad334967
Cr-Commit-Position: refs/heads/master@{#294074}

[lazyboy, 2014-09-09 02:02:34]

lazyboy@chromium.org changed reviewers:
+ fsamuel@chromium.org

[Fady Samuel, 2014-09-09 02:10:24]

https://codereview.chromium.org/556723002/diff/1/chrome/browser/guest_view/mi...
File
chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc
(right):

https://codereview.chromium.org/556723002/diff/1/chrome/browser/guest_view/mi...
chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc:27:
#if defined(ENABLE_PRINTING)
TODO to move this stuff to extensions perhaps?

https://codereview.chromium.org/556723002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
(right):

https://codereview.chromium.org/556723002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:103:
delegate_->OnAttachHelpers(web_contents());
Maybe this should be AttachHelpers not OnAttachHelpers, because we're not
observing attachment, we are attaching.

[lazyboy, 2014-09-09 06:57:42]

Comments addressed in patchset #2

https://codereview.chromium.org/556723002/diff/1/chrome/browser/guest_view/mi...
File
chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc
(right):

https://codereview.chromium.org/556723002/diff/1/chrome/browser/guest_view/mi...
chrome/browser/guest_view/mime_handler_view/chrome_mime_handler_view_guest_delegate.cc:27:
#if defined(ENABLE_PRINTING)
On 2014/09/09 02:10:24, Fady Samuel wrote:
> TODO to move this stuff to extensions perhaps?

Done.

https://codereview.chromium.org/556723002/diff/1/extensions/browser/guest_vie...
File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
(right):

https://codereview.chromium.org/556723002/diff/1/extensions/browser/guest_vie...
extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:103:
delegate_->OnAttachHelpers(web_contents());
On 2014/09/09 02:10:24, Fady Samuel wrote:
> Maybe this should be AttachHelpers not OnAttachHelpers, because we're not
> observing attachment, we are attaching.

Done.

[Fady Samuel, 2014-09-09 14:30:29]

https://codereview.chromium.org/556723002/diff/20001/extensions/browser/guest...
File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
(right):

https://codereview.chromium.org/556723002/diff/20001/extensions/browser/guest...
extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:42:
ExtensionsAPIClient::Get()->CreateMimeHandlerViewGuestDelegate()) {
Perhaps we can pass in "this" into "CreateMimeHandlerViewGuestDelegate"?

https://codereview.chromium.org/556723002/diff/20001/extensions/browser/guest...
extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:103:
delegate_->AttachHelpers(web_contents());
If the delegate_ knows about this, then we don't need to pass in web_contents().

[lazyboy, 2014-09-09 15:49:34]

Comments addressed in patchset #3

https://chromiumcodereview.appspot.com/556723002/diff/20001/extensions/browse...
File extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc
(right):

https://chromiumcodereview.appspot.com/556723002/diff/20001/extensions/browse...
extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:42:
ExtensionsAPIClient::Get()->CreateMimeHandlerViewGuestDelegate()) {
On 2014/09/09 14:30:29, Fady Samuel wrote:
> Perhaps we can pass in "this" into "CreateMimeHandlerViewGuestDelegate"?

Done.

https://chromiumcodereview.appspot.com/556723002/diff/20001/extensions/browse...
extensions/browser/guest_view/mime_handler_view/mime_handler_view_guest.cc:103:
delegate_->AttachHelpers(web_contents());
On 2014/09/09 14:30:29, Fady Samuel wrote:
> If the delegate_ knows about this, then we don't need to pass in
web_contents().

Done.

[Fady Samuel, 2014-09-09 15:50:50]

lgtm

[lazyboy, 2014-09-09 16:06:06]

lazyboy@chromium.org changed reviewers:
+ rockot@chromium.org

[lazyboy, 2014-09-09 16:06:06]

+Ken for OWNERS review of the following files:
chrome/browser/extensions/api/chrome_extensions_api_client.h/cc
extensions/browser/api/extensions_api_client.h/cc
extensions/browser/BUILD.gn
extensions/extensions.gyp

[Ken Rockot(use gerrit already), 2014-09-09 23:33:09]

lgtm

https://codereview.chromium.org/556723002/diff/80001/chrome/browser/extension...
File chrome/browser/extensions/api/chrome_extensions_api_client.h (right):

https://codereview.chromium.org/556723002/diff/80001/chrome/browser/extension...
chrome/browser/extensions/api/chrome_extensions_api_client.h:13: class
MimeHandlerViewGuest;
nit: I would argue that this is redundant since you're implementing an interface
that must have already declared its existence.

[lazyboy, 2014-09-09 23:44:35]

Comments addressed in patchset #6.

Thanks for the review.

https://chromiumcodereview.appspot.com/556723002/diff/80001/chrome/browser/ex...
File chrome/browser/extensions/api/chrome_extensions_api_client.h (right):

https://chromiumcodereview.appspot.com/556723002/diff/80001/chrome/browser/ex...
chrome/browser/extensions/api/chrome_extensions_api_client.h:13: class
MimeHandlerViewGuest;
On 2014/09/09 23:33:08, Ken Rockot wrote:
> nit: I would argue that this is redundant since you're implementing an
interface
> that must have already declared its existence.

Right, removed.
Done.

[lazyboy, 2014-09-10 00:21:30]

The CQ bit was checked by lazyboy@chromium.org

[commit-bot: I haz the power, 2014-09-10 00:30:08]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/lazyboy@chromium.org/556723002/100001

[commit-bot: I haz the power, 2014-09-10 01:59:37]

Committed patchset #6 (id:100001) as f79bdfabe9fa63c1bfa11e020097012871ed3a17

[commit-bot: I haz the power, 2014-09-10 03:57:41]

Patchset 6 (id:??) landed as
https://crrev.com/9b204d37f67e3f4a07f11ba4e887a028ad334967
Cr-Commit-Position: refs/heads/master@{#294074}