Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(190)

Unified Diff: tools/perf/page_sets/PRESUBMIT.py

Issue 556003002: [telemetry] Use consistent bucket naming. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Remove code that says "remove this" Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « no previous file | tools/telemetry/cloud_storage » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: tools/perf/page_sets/PRESUBMIT.py
diff --git a/tools/perf/page_sets/PRESUBMIT.py b/tools/perf/page_sets/PRESUBMIT.py
index faf0503d0e15c7565996422a9c5dcc26f114a9b3..a29e246853f099c75b588d02d3f1b39a94f4a278 100644
--- a/tools/perf/page_sets/PRESUBMIT.py
+++ b/tools/perf/page_sets/PRESUBMIT.py
@@ -82,17 +82,19 @@ def _SyncFilesToCloud(input_api, output_api):
continue
try:
- bucket_input = raw_input('Uploading to Cloud Storage: %s\n'
- 'Is this file [P]ublic or Google-[i]nternal?'
- % file_path).lower()
- if 'public'.startswith(bucket_input):
+ bucket_input = raw_input(
tonyg 2014/09/10 00:15:01 Just a thought, but it looks like we could auto-ge
dtu 2014/09/12 02:39:15 Done.
+ 'Uploading to Cloud Storage: %s\n'
+ 'Which bucket should this go in? (public, partner, internal) '
+ % file_path).lower()
+ if bucket_input == 'public':
bucket = cloud_storage.PUBLIC_BUCKET
- elif ('internal'.startswith(bucket_input) or
- 'google-internal'.startswith(bucket_input)):
+ elif bucket_input == 'partner':
+ bucket = cloud_storage.PARTNER_BUCKET
+ elif bucket_input == 'internal':
bucket = cloud_storage.INTERNAL_BUCKET
else:
results.append(output_api.PresubmitError(
- 'Response was neither "public" nor "internal": %s' % bucket_input))
+ '"%s" was not "public," "partner," or "internal"' % bucket_input))
return results
cloud_storage.Insert(bucket, file_hash, file_path)
« no previous file with comments | « no previous file | tools/telemetry/cloud_storage » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698