Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(11)

Issue 556003002: [telemetry] Use consistent bucket naming. (Closed)

Created:
6 years, 3 months ago by dtu
Modified:
6 years, 3 months ago
Reviewers:
tonyg
CC:
chromium-reviews, telemetry+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

[telemetry] Use consistent bucket naming. Also catch 401 errors. BUG=None. TEST=None. Committed: https://crrev.com/4ad23a40c79a3b80f64b95b22a55c723cfd03a0d Cr-Commit-Position: refs/heads/master@{#294921}

Patch Set 1 #

Patch Set 2 : Remove code that says "remove this" #

Total comments: 2

Patch Set 3 : Use BUCKET_ALIASES. #

Patch Set 4 : Unit tests. #

Unified diffs Side-by-side diffs Delta from patch set Stats (+33 lines, -37 lines) Patch
M tools/perf/page_sets/PRESUBMIT.py View 1 2 1 chunk +8 lines, -10 lines 0 comments Download
M tools/telemetry/cloud_storage View 1 2 3 chunks +5 lines, -10 lines 0 comments Download
M tools/telemetry/telemetry/page/page_set_archive_info.py View 1 2 chunks +1 line, -15 lines 0 comments Download
M tools/telemetry/telemetry/unittest/system_stub.py View 1 2 3 1 chunk +8 lines, -2 lines 0 comments Download
M tools/telemetry/telemetry/util/cloud_storage.py View 1 2 3 2 chunks +11 lines, -0 lines 0 comments Download

Messages

Total messages: 12 (4 generated)
dtu
6 years, 3 months ago (2014-09-10 00:12:30 UTC) #2
tonyg
lgtm https://codereview.chromium.org/556003002/diff/20001/tools/perf/page_sets/PRESUBMIT.py File tools/perf/page_sets/PRESUBMIT.py (right): https://codereview.chromium.org/556003002/diff/20001/tools/perf/page_sets/PRESUBMIT.py#newcode85 tools/perf/page_sets/PRESUBMIT.py:85: bucket_input = raw_input( Just a thought, but it ...
6 years, 3 months ago (2014-09-10 00:15:02 UTC) #3
dtu
https://chromiumcodereview.appspot.com/556003002/diff/20001/tools/perf/page_sets/PRESUBMIT.py File tools/perf/page_sets/PRESUBMIT.py (right): https://chromiumcodereview.appspot.com/556003002/diff/20001/tools/perf/page_sets/PRESUBMIT.py#newcode85 tools/perf/page_sets/PRESUBMIT.py:85: bucket_input = raw_input( On 2014/09/10 00:15:01, tonyg wrote: > ...
6 years, 3 months ago (2014-09-12 02:39:15 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556003002/40001
6 years, 3 months ago (2014-09-12 02:40:13 UTC) #6
commit-bot: I haz the power
Try jobs failed on following builders: mac_chromium_rel_swarming on tryserver.chromium.mac (http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_swarming/builds/12994)
6 years, 3 months ago (2014-09-12 03:32:36 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/556003002/60001
6 years, 3 months ago (2014-09-15 20:56:01 UTC) #10
commit-bot: I haz the power
Committed patchset #4 (id:60001) as 6f357fbaa0d83ec79fd54dcdaf589ac993ce2d03
6 years, 3 months ago (2014-09-15 23:35:58 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-15 23:38:26 UTC) #12
Message was sent while issue was closed.
Patchset 4 (id:??) landed as
https://crrev.com/4ad23a40c79a3b80f64b95b22a55c723cfd03a0d
Cr-Commit-Position: refs/heads/master@{#294921}

Powered by Google App Engine
This is Rietveld 408576698