Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1002)

Unified Diff: content/browser/web_contents/web_contents_impl.cc

Issue 554893002: [WORK_IN_PROGRESS] PDF::Save() fix for out-of-process-pdf. Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: with print dialog fix (aura only) Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « components/pdf/renderer/ppb_pdf_impl.cc ('k') | extensions/browser/api/extensions_api_client.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: content/browser/web_contents/web_contents_impl.cc
diff --git a/content/browser/web_contents/web_contents_impl.cc b/content/browser/web_contents/web_contents_impl.cc
index b34f55c9edb9e37a8349a26317f054f8e799a196..9ca6ecc573f28f5e2f919e819673a0ae92e33f2f 100644
--- a/content/browser/web_contents/web_contents_impl.cc
+++ b/content/browser/web_contents/web_contents_impl.cc
@@ -2171,12 +2171,18 @@ bool WebContentsImpl::SavePage(const base::FilePath& main_file,
void WebContentsImpl::SaveFrame(const GURL& url,
const Referrer& referrer) {
+ printf("WCI::SaveFrame, url = %s\n",
+ url.possibly_invalid_spec().c_str());
+
if (!GetURL().is_valid())
return;
+ printf("is_valid\n");
bool is_main_frame = (url == GetURL());
+ printf("is_main_frame: %d\n", is_main_frame);
DownloadManager* dlm =
BrowserContext::GetDownloadManager(GetBrowserContext());
+ printf("dlm = [%p]\n", dlm);
if (!dlm)
return;
int64 post_id = -1;
@@ -2190,6 +2196,7 @@ void WebContentsImpl::SaveFrame(const GURL& url,
params->set_referrer(referrer);
params->set_post_id(post_id);
params->set_prefer_cache(true);
+ printf("post_id >= 0: %d\n", post_id >= 0);
if (post_id >= 0)
params->set_method("POST");
params->set_prompt(true);
« no previous file with comments | « components/pdf/renderer/ppb_pdf_impl.cc ('k') | extensions/browser/api/extensions_api_client.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698