chrome/browser/ui/webui/options/search_engine_manager_handler.cc - Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/options/search_engine_manager_handler.cc

Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_2

Patch Set: reannotate createItem() Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/options/search_engine_manager_engine_list.js ('K') | « chrome/browser/resources/options/startup_overlay.js ('k') | chrome/common/extensions/docs/examples/extensions/plugin_settings/options/js/inline_editable_list.js » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/ui/webui/options/search_engine_manager_handler.cc

diff --git a/chrome/browser/ui/webui/options/search_engine_manager_handler.cc b/chrome/browser/ui/webui/options/search_engine_manager_handler.cc

index 3ac89ac88791b6bcf20b7bb8bb109f0cc10396e0..271a69d0a68b48bec9f6471d87898fd35a94eee3 100644

--- a/chrome/browser/ui/webui/options/search_engine_manager_handler.cc

+++ b/chrome/browser/ui/webui/options/search_engine_manager_handler.cc

@@ -172,6 +172,10 @@ base::DictionaryValue* SearchEngineManagerHandler::CreateDictionaryForEngine(

TemplateURLTableModel* table_model = list_controller_->table_model();

const TemplateURL* template_url = list_controller_->GetTemplateURL(index);

+ // The items which are to be written into |dict| are also described in

+ // chrome/browser/resources/options/search_engine_manager_engine_list.js

+ // in @typedef for SearchEngine. Please update it whenever you add or remove

+ // any keys here.

base::DictionaryValue* dict = new base::DictionaryValue();

dict->SetString("name", template_url->short_name());

dict->SetString("displayName", table_model->GetText(