Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(338)

Unified Diff: chrome/browser/resources/options/search_engine_manager.js

Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_2
Patch Set: reannotate createItem() Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/resources/options/search_engine_manager.js
diff --git a/chrome/browser/resources/options/search_engine_manager.js b/chrome/browser/resources/options/search_engine_manager.js
index c3e8971ad1ace2fc3c2d404f88bd45cd8eb70a00..ce31ef6918163782cd2125798876f2c1a896a934 100644
--- a/chrome/browser/resources/options/search_engine_manager.js
+++ b/chrome/browser/resources/options/search_engine_manager.js
@@ -62,7 +62,7 @@ cr.define('options', function() {
/**
* Sets up the given list as a search engine list
- * @param {cr.ui.List} list The list to set up.
+ * @param {HTMLElement} list The list to set up.
* @private
*/
setUpList_: function(list) {
@@ -73,9 +73,9 @@ cr.define('options', function() {
/**
* Updates the search engine list with the given entries.
* @private
- * @param {Array} defaultEngines List of possible default search engines.
- * @param {Array} otherEngines List of other search engines.
- * @param {Array} keywords List of keywords from extensions.
+ * @param {!Array} defaultEngines List of possible default search engines.
+ * @param {!Array} otherEngines List of other search engines.
+ * @param {!Array} keywords List of keywords from extensions.
*/
updateSearchEngineList_: function(defaultEngines, otherEngines, keywords) {
this.defaultsList_.dataModel = new ArrayDataModel(defaultEngines);

Powered by Google App Engine
This is Rietveld 408576698