chrome/browser/resources/options/options.js - Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/options/options.js

Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@H_options_errors_2

Patch Set: reannotate createItem() Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/resources/options/hotword_confirm_dialog.js ('k') | chrome/browser/resources/options/password_manager.js » ('j') | chrome/browser/resources/options/search_engine_manager_engine_list.js » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: chrome/browser/resources/options/options.js

diff --git a/chrome/browser/resources/options/options.js b/chrome/browser/resources/options/options.js

index 5c2bebb0edc33ada062c6a283b44e7299e1881b3..9e053a0eb1130774c5d65ce4ca56b99c734fd7ce 100644

--- a/chrome/browser/resources/options/options.js

+++ b/chrome/browser/resources/options/options.js

@@ -93,8 +93,8 @@ function load() {

'do-not-track-confirm-overlay',

/** @type {HTMLInputElement} */($('do-not-track-confirm-ok')),

/** @type {HTMLInputElement} */($('do-not-track-confirm-cancel')),

- $('do-not-track-enabled').pref,

- $('do-not-track-enabled').metric),

+ $('do-not-track-enabled')['pref'],

+ $('do-not-track-enabled')['metric']),

BrowserOptions.getInstance());

// 'spelling-enabled-control' element is only present on Chrome branded

// builds.

@@ -106,8 +106,8 @@ function load() {

'spelling-confirm-overlay',

/** @type {HTMLInputElement} */($('spelling-confirm-ok')),

/** @type {HTMLInputElement} */($('spelling-confirm-cancel')),

- $('spelling-enabled-control').pref,

- $('spelling-enabled-control').metric),

+ $('spelling-enabled-control')['pref'],

+ $('spelling-enabled-control')['metric']),

BrowserOptions.getInstance());

}

PageManager.registerOverlay(new HotwordConfirmDialog(),