Compile chrome://settings, part 4: 149 proper errors left

chrome/browser/resources/options/search_engine_manager_engine_list.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
+/**
+ * @typedef {{
+ * canBeDefault: boolean,
+ * canBeEdited: boolean,
+ * canBeRemoved: boolean,
+ * default: boolean,
+ * displayName: string,
+ * extension: (Object|undefined),
+ * iconURL: (string|undefined),
+ * isExtension: boolean,
+ * keyword: string,
+ * modelIndex: string,
+ * name: string,
+ * url: string,
+ * urlLocked: boolean

[Dan Beam, 2014/09/12 23:29:09]

nit: indent keys

[Vitaly Pavlenko, 2014/09/12 23:51:59]

Done.

+ * }}
+ * @see chrome/browser/ui/webui/options/search_engine_manager_handler.cc
+ */
+var SearchEngine;
+
 cr.define('options.search_engines', function() {
   /** @const */ var ControlledSettingIndicator =
                     options.ControlledSettingIndicator;
   /** @const */ var InlineEditableItemList = options.InlineEditableItemList;
   /** @const */ var InlineEditableItem = options.InlineEditableItem;
   /** @const */ var ListSelectionController = cr.ui.ListSelectionController;
 
   /**
    * Creates a new search engine list item.
-   * @param {Object} searchEngine The search engine this represents.
+   * @param {SearchEngine} searchEngine The search engine this represents.
    * @constructor
-   * @extends {cr.ui.ListItem}
+   * @extends {options.InlineEditableItem}
    */
   function SearchEngineListItem(searchEngine) {
     var el = cr.doc.createElement('div');
     el.searchEngine_ = searchEngine;
     SearchEngineListItem.decorate(el);
     return el;
   }
 
   /**
    * Decorates an element as a search engine list item.
@@ skipping 35 matching lines @@
      */
     waitingForValidation_: false,
 
     /**
      * Whether or not the current set of input is known to be valid.
      * @type {boolean}
      * @private
      */
     currentlyValid_: false,
 
+    /**
+     * @type {?SearchEngine}
+     */
+    searchEngine_: null,
+
     /** @override */
     decorate: function() {
       InlineEditableItem.prototype.decorate.call(this);
 
       var engine = this.searchEngine_;
 
       if (engine.modelIndex == '-1') {
         this.isPlaceholder = true;
         engine.name = '';
         engine.keyword = '';
@@ skipping 57 matching lines @@
             // Don't select the row when clicking the button.
             e.stopPropagation();
             // Don't focus on the button.
             e.preventDefault();
           };
           urlWithButtonEl.appendChild(makeDefaultButtonEl);
         }
       }
 
       // Do final adjustment to the input fields.
-      this.nameField_ = nameEl.querySelector('input');
+      this.nameField_ = /** @type {HTMLElement} */(
+          nameEl.querySelector('input'));
       // The editable field uses the raw name, not the display name.
       this.nameField_.value = engine.name;
-      this.keywordField_ = keywordEl.querySelector('input');
-      this.urlField_ = urlEl.querySelector('input');
+      this.keywordField_ = /** @type {HTMLElement} */(
+          keywordEl.querySelector('input'));
+      this.urlField_ = /** @type {HTMLElement} */(urlEl.querySelector('input'));
 
       if (engine.urlLocked)
         this.urlField_.disabled = true;
 
       if (engine.isExtension)
         this.nameField_.disabled = true;
 
       if (this.isPlaceholder) {
         this.nameField_.placeholder =
             loadTimeData.getString('searchEngineTableNamePlaceholder');
@@ skipping 129 matching lines @@
         this.urlField_.setCustomValidity('');
       } else {
         this.urlField_.setCustomValidity(
             loadTimeData.getString('editSearchEngineInvalidURLToolTip'));
       }
 
       this.currentlyValid_ = validity.name && validity.keyword && validity.url;
     },
   };
 
+  /**
+   * @constructor
+   * @extends {options.InlineEditableItemList}
+   */
   var SearchEngineList = cr.ui.define('list');
 
   SearchEngineList.prototype = {
     __proto__: InlineEditableItemList.prototype,
 
-    /** @override */
+    /**
+     * @override
+     * @param {SearchEngine} searchEngine
+     */
     createItem: function(searchEngine) {
       return new SearchEngineListItem(searchEngine);
     },
 
     /** @override */
     deleteItemAtIndex: function(index) {
       var modelIndex = this.dataModel.item(index).modelIndex;
       chrome.send('removeSearchEngine', [String(modelIndex)]);
     },
 
@@ skipping 14 matching lines @@
     },
   };
 
   // Export
   return {
     SearchEngineList: SearchEngineList
   };
 
 });