Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(211)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 552883002: Compile chrome://settings, part 4: 149 proper errors left (Closed)

Created:
6 years, 3 months ago by Vitaly Pavlenko
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, dbeam+watch-options_chromium.org, extensions-reviews_chromium.org, arv+watch_chromium.org, chromium-apps-reviews_chromium.org, gcasto+watchlist_chromium.org, mkwst+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@H_options_errors_2
Project:
chromium
Visibility:
Public.

Description

Compile chrome://settings, part 4: 149 proper errors left R=dbeam@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . chrome/browser/resources/options/compiled_resources.gyp && ninja -C out/Default | grep ERROR | wc -l Committed: https://crrev.com/ac19d9327f7390363e30114f033c9bc9603fd5c0 Cr-Commit-Position: refs/heads/master@{#295126}

Patch Set 1 #

Patch Set 2 : reannotate createItem() #

Total comments: 2

Patch Set 3 : fix nit #

Patch Set 4 : revert changes to doc js #

Patch Set 5 : rebase #

Patch Set 6 : fixed assert #

Unified diffs Side-by-side diffs Delta from patch set Stats (+62 lines, -26 lines) Patch
M chrome/browser/resources/options/hotword_confirm_dialog.js View 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/options.js View 1 2 3 4 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/password_manager.js View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/password_manager_list.js View 2 chunks +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/search_engine_manager.js View 2 chunks +4 lines, -4 lines 0 comments Download
M chrome/browser/resources/options/search_engine_manager_engine_list.js View 1 2 5 chunks +38 lines, -6 lines 0 comments Download
M chrome/browser/resources/options/search_page.js View 1 2 3 4 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/resources/options/settings_dialog.js View 1 2 3 4 5 1 chunk +2 lines, -2 lines 0 comments Download
M chrome/browser/resources/options/startup_overlay.js View 1 2 3 4 5 1 chunk +4 lines, -4 lines 0 comments Download
M chrome/browser/ui/webui/options/search_engine_manager_handler.cc View 1 chunk +4 lines, -0 lines 0 comments Download

Messages

Total messages: 14 (4 generated)
Vitaly Pavlenko
6 years, 3 months ago (2014-09-08 22:35:40 UTC) #1
Dan Beam
will get to this tonight or (more likely) tomorrow
6 years, 3 months ago (2014-09-09 03:10:32 UTC) #2
Vitaly Pavlenko
On 2014/09/09 03:10:32, Dan Beam wrote: > will get to this tonight or (more likely) ...
6 years, 3 months ago (2014-09-12 17:45:13 UTC) #3
Dan Beam
lgtm https://chromiumcodereview.appspot.com/552883002/diff/20001/chrome/browser/resources/options/search_engine_manager_engine_list.js File chrome/browser/resources/options/search_engine_manager_engine_list.js (right): https://chromiumcodereview.appspot.com/552883002/diff/20001/chrome/browser/resources/options/search_engine_manager_engine_list.js#newcode19 chrome/browser/resources/options/search_engine_manager_engine_list.js:19: * urlLocked: boolean nit: indent keys
6 years, 3 months ago (2014-09-12 23:29:09 UTC) #4
Vitaly Pavlenko
https://chromiumcodereview.appspot.com/552883002/diff/20001/chrome/browser/resources/options/search_engine_manager_engine_list.js File chrome/browser/resources/options/search_engine_manager_engine_list.js (right): https://chromiumcodereview.appspot.com/552883002/diff/20001/chrome/browser/resources/options/search_engine_manager_engine_list.js#newcode19 chrome/browser/resources/options/search_engine_manager_engine_list.js:19: * urlLocked: boolean On 2014/09/12 23:29:09, Dan Beam wrote: ...
6 years, 3 months ago (2014-09-12 23:51:59 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552883002/80001
6 years, 3 months ago (2014-09-16 02:19:15 UTC) #7
commit-bot: I haz the power
Try jobs failed on following builders: linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_chromeos_rel_swarming/builds/14556) linux_chromium_rel_swarming on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_rel_swarming/builds/16553) mac_chromium_rel_swarming ...
6 years, 3 months ago (2014-09-16 03:41:35 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/552883002/100001
6 years, 3 months ago (2014-09-16 18:21:12 UTC) #12
commit-bot: I haz the power
Committed patchset #6 (id:100001) as c77832123a7b1bbe201e0e932366be846c1016f3
6 years, 3 months ago (2014-09-16 19:33:58 UTC) #13
commit-bot: I haz the power
6 years, 3 months ago (2014-09-16 19:34:39 UTC) #14
Message was sent while issue was closed. 
Patchset 6 (id:??) landed as
https://crrev.com/ac19d9327f7390363e30114f033c9bc9603fd5c0
Cr-Commit-Position: refs/heads/master@{#295126}

Powered by Google App Engine
This is Rietveld 408576698