Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(94)

Unified Diff: ui/events/event_processor.cc

Issue 552503003: Introduce EventProcessor::OnEventProcessingStarted() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: two comments from sadrul Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « ui/events/event_processor.h ('k') | ui/events/event_processor_unittest.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: ui/events/event_processor.cc
diff --git a/ui/events/event_processor.cc b/ui/events/event_processor.cc
index 25c8c3fae92ca2b74e723fce69ee2fe6792b6c49..ff55dbb997d34d5e81e215f22acaad24840b6ed1 100644
--- a/ui/events/event_processor.cc
+++ b/ui/events/event_processor.cc
@@ -14,7 +14,6 @@ EventDispatchDetails EventProcessor::OnEventFromSource(Event* event) {
CHECK(root);
EventTargeter* targeter = root->GetEventTargeter();
CHECK(targeter);
- PrepareEventForDispatch(event);
// If |event| is in the process of being dispatched or has already been
// dispatched, then dispatch a copy of the event instead.
@@ -26,9 +25,10 @@ EventDispatchDetails EventProcessor::OnEventFromSource(Event* event) {
event_to_dispatch = event_copy.get();
}
- EventTarget* target = targeter->FindTargetForEvent(root, event_to_dispatch);
EventDispatchDetails details;
- while (target) {
+ OnEventProcessingStarted(event_to_dispatch);
+ EventTarget* target = targeter->FindTargetForEvent(root, event_to_dispatch);
sadrul 2014/09/16 17:16:53 You don't need to find the target if you aren't go
tdanderson 2014/09/23 21:30:27 Yes, good point... also, FindTargetForEvent() may
+ while (target && !event_to_dispatch->handled()) {
details = DispatchEvent(target, event_to_dispatch);
if (!dispatch_original_event) {
@@ -51,7 +51,7 @@ EventDispatchDetails EventProcessor::OnEventFromSource(Event* event) {
return details;
}
-void EventProcessor::PrepareEventForDispatch(Event* event) {
+void EventProcessor::OnEventProcessingStarted(Event* event) {
}
void EventProcessor::OnEventProcessingFinished(Event* event) {
« no previous file with comments | « ui/events/event_processor.h ('k') | ui/events/event_processor_unittest.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698