Issue 55233009: Fix attributeChanged signature in WebUI (needs latest cherry-pick of custom

Keyboard Shortcuts

	File
u :	up to issue
m :	publish + mail comments
M :	edit review message
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line
<Enter> :	respond to / edit current comment
d :	mark current comment as done

	Issue
u :	up to list of issues
m :	publish + mail comments
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue
# :	close issue

	Comment/message editing
<Ctrl> + s or <Ctrl> + Enter :	save comment
<Esc> :	cancel edit

Issue 55233009: Fix attributeChanged signature in WebUI (needs latest cherry-pick of custom (Closed)

Can't Edit
Can't Publish+Mail
Start Review

Created:
3 years, 9 months ago by Siggi Cherem (dart-lang)

Modified:
3 years, 9 months ago

Reviewers:
Jennifer Messerly

CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org

Base URL:
git@github.com:dart-lang/web-ui.git@master

Visibility:
Public.

Fix attributeChanged signature in WebUI (needs latest cherry-pick of custom elements to avoid errors). R=jmesserly@google.com Committed: https://github.com/dart-lang/web-ui/commit/f0bfc2d

Created: 3 years, 9 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+3 lines, -9 lines)			Patch
M	lib/testing/render_test.dart	View	1 chunk	+1 line, -1 line	0 comments	Download
M	lib/web_ui.dart	View	1 chunk	+0 lines, -6 lines	0 comments	Download
M	pubspec.yaml	View	2 chunks	+2 lines, -2 lines	0 comments	Download

Trybot results:

Commit queue not available (can’t edit this change).

Total messages: 3 (0 generated)

Siggi Cherem (dart-lang)

3 years, 9 months ago (2013-11-04 23:53:44 UTC) #3

Message was sent while issue was closed.

Committed patchset #1 manually as rf0bfc2d (presubmit successful).