Chromium Code Reviews
Help | Chromium Project | Sign in
(2)

Issue 55233009: Fix attributeChanged signature in WebUI (needs latest cherry-pick of custom (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 7 months ago by Siggi Cherem (dart-lang)
Modified:
1 year, 7 months ago
Reviewers:
John Messerly
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Fix attributeChanged signature in WebUI (needs latest cherry-pick of custom elements to avoid errors). R=jmesserly@google.com Committed: https://github.com/dart-lang/web-ui/commit/f0bfc2d

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+3 lines, -9 lines) Patch
M lib/testing/render_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/web_ui.dart View 1 chunk +0 lines, -6 lines 0 comments Download
M pubspec.yaml View 2 chunks +2 lines, -2 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
1 year, 7 months ago (2013-11-04 23:44:22 UTC) #1
John Messerly
lgtm
1 year, 7 months ago (2013-11-04 23:46:37 UTC) #2
Siggi Cherem (dart-lang)
1 year, 7 months ago (2013-11-04 23:53:44 UTC) #3
Message was sent while issue was closed.
Committed patchset #1 manually as rf0bfc2d (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d