Chromium Code Reviews
Help | Chromium Project | Sign in
(4)

Issue 55143003: webui fixes for 0.8.9 (Closed)

Can't Edit
Can't Publish+Mail
Start Review
Created:
1 year, 8 months ago by Siggi Cherem (dart-lang)
Modified:
1 year, 8 months ago
Reviewers:
John Messerly
CC:
reviews_dartlang.org, web-ui-dev+reviews_dartlang.org
Base URL:
git@github.com:dart-lang/web-ui.git@master
Visibility:
Public.

Description

Patch Set 1 #

Patch Set 2 : #

Total comments: 1
Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -121 lines) Patch
M bin/dwc.dart View 1 chunk +1 line, -1 line 0 comments Download
M build.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M example/explainer/build_examples.dart View 2 chunks +3 lines, -3 lines 0 comments Download
M example/todomvc/build.dart View 1 chunk +2 lines, -3 lines 0 comments Download
M example/wiki_css/build.dart View 1 chunk +1 line, -3 lines 0 comments Download
M lib/component_build.dart View 1 chunk +1 line, -1 line 0 comments Download
M lib/dwc.dart View 1 2 chunks +3 lines, -3 lines 0 comments Download
M lib/observe/observable.dart View 2 chunks +1 line, -2 lines 0 comments Download
M lib/safe_html.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/src/code_printer.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/src/dart_parser.dart View 3 chunks +15 lines, -19 lines 0 comments Download
M lib/src/file_system/console.dart View 2 chunks +2 lines, -2 lines 0 comments Download
M lib/src/info.dart View 2 chunks +1 line, -3 lines 0 comments Download
M lib/src/utils.dart View 1 3 chunks +6 lines, -6 lines 0 comments Download
M lib/src/utils_observe.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/templating.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M lib/testing/render_test.dart View 1 1 chunk +3 lines, -4 lines 0 comments Download
M lib/watcher.dart View 1 chunk +0 lines, -1 line 0 comments Download
M lib/web_ui.dart View 1 chunk +0 lines, -2 lines 0 comments Download
M pubspec.yaml View 1 1 chunk +16 lines, -17 lines 1 comment Download
M test/data/input/bind_hyphenated_attribute_test.html View 1 chunk +2 lines, -0 lines 0 comments Download
M test/html5_utils_test.dart View 1 1 chunk +2 lines, -5 lines 0 comments Download
M test/observe_test.dart View 1 chunk +1 line, -1 line 0 comments Download
M test/paths_test.dart View 1 1 chunk +1 line, -1 line 0 comments Download
M test/perf/compare.dart View 7 chunks +13 lines, -14 lines 0 comments Download
M test/perf/perf.dart View 1 chunk +6 lines, -8 lines 0 comments Download
M test/perf/update_json.dart View 3 chunks +4 lines, -5 lines 0 comments Download
M test/run_all.dart View 2 chunks +1 line, -8 lines 0 comments Download
Trybot results:
Commit: CQ not working?

Messages

Total messages: 3 (0 generated)
Siggi Cherem (dart-lang)
lots of breaking changes (lot of deprecated APIs were removed) I didn't fix entirely the ...
1 year, 8 months ago (2013-10-31 22:08:03 UTC) #1
John Messerly
lgtm
1 year, 8 months ago (2013-10-31 23:20:17 UTC) #2
Siggi Cherem (dart-lang)
1 year, 8 months ago (2013-10-31 23:29:52 UTC) #3
Message was sent while issue was closed.
Committed patchset #2 manually as r823f847 (presubmit successful).
Sign in to reply to this message.

Powered by Google App Engine
RSS Feeds Recent Issues | This issue
This is Rietveld 1f9106d