Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(143)

Issue 548773004: Rename process_log_utils and related things. (Closed)

Created:
6 years, 3 months ago by qyearsley
Modified:
6 years, 3 months ago
CC:
chromium-reviews, pgervais+watch_chromium.org, kjellander-cc_chromium.org, cmp-cc_chromium.org, stip+watch_chromium.org, eakuefner, rnephew (Wrong account)
Base URL:
https://chromium.googlesource.com/chromium/tools/build.git@master
Project:
tools
Visibility:
Public.

Description

Rename process_log_utils and related things. I've wanted to do this for a looooooong time. - process_log_utils.py -> performance_log_processor.py (Because the main purpose of that module is that it contains PerformanceLogProcessor and subclasses). - runtest_annotator_test.py -> performance_log_processor_test.py (because it's a test of the above module). And, in runtest.py, instances of these classes have been called: log parser log processor results tracker etc. This CL changes runtest.py to use the term "log processor" for consistency. All the changed modules pass pylint. BUG= Committed: http://src.chromium.org/viewvc/chrome?view=rev&revision=291894

Patch Set 1 #

Total comments: 1

Patch Set 2 : Renamed remaining occurrences of "results_tracker". #

Unified diffs Side-by-side diffs Delta from patch set Stats (+186 lines, -1417 lines) Patch
M scripts/slave/annotation_utils.py View 1 4 chunks +24 lines, -24 lines 0 comments Download
A + scripts/slave/performance_log_processor.py View 3 chunks +58 lines, -56 lines 0 comments Download
D scripts/slave/process_log_utils.py View 1 chunk +0 lines, -842 lines 0 comments Download
M scripts/slave/runtest.py View 1 32 chunks +95 lines, -101 lines 0 comments Download
A + scripts/slave/unittests/performance_log_processor_test.py View 8 chunks +9 lines, -15 lines 0 comments Download
D scripts/slave/unittests/runtest_annotator_test.py View 1 chunk +0 lines, -379 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
qyearsley
6 years, 3 months ago (2014-09-09 04:41:55 UTC) #2
ghost stip (do not use)
quinten, can you coordinate with sullivan@ w.r.t. https://chromiumcodereview.appspot.com/545803002/? I think you'll have minimal conflicts, but ...
6 years, 3 months ago (2014-09-09 17:47:57 UTC) #3
sullivan
On 2014/09/09 17:47:57, stip wrote: > quinten, can you coordinate with sullivan@ w.r.t. > https://chromiumcodereview.appspot.com/545803002/ ...
6 years, 3 months ago (2014-09-09 17:53:30 UTC) #4
qyearsley
On 2014/09/09 17:53:30, sullivan wrote: > On 2014/09/09 17:47:57, stip wrote: > > quinten, can ...
6 years, 3 months ago (2014-09-09 18:30:02 UTC) #5
ghost stip (do not use)
lgtm https://chromiumcodereview.appspot.com/548773004/diff/1/scripts/slave/unittests/runtest_annotator_test.py File scripts/slave/unittests/runtest_annotator_test.py (left): https://chromiumcodereview.appspot.com/548773004/diff/1/scripts/slave/unittests/runtest_annotator_test.py#oldcode1 scripts/slave/unittests/runtest_annotator_test.py:1: #!/usr/bin/env python we finally renamed this file :)
6 years, 3 months ago (2014-09-09 21:45:22 UTC) #6
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/qyearsley@chromium.org/548773004/20001
6 years, 3 months ago (2014-09-09 22:23:56 UTC) #8
commit-bot: I haz the power
6 years, 3 months ago (2014-09-09 22:25:33 UTC) #9
Message was sent while issue was closed.
Committed patchset #2 (id:20001) as 291894

Powered by Google App Engine
This is Rietveld 408576698