mojo: Specialize native type arrays.

mojo: Specialize native type arrays.

R=sdefresne@chromium.org,cmasone@chromium.org

Committed: https://crrev.com/1db711fe8d18883afe49a57dbd32aa7688de4206
Cr-Commit-Position: refs/heads/master@{#294354}

[Chris Masone, 2014-09-09 14:20:26]

https://codereview.chromium.org/548343005/diff/1/mojo/public/tools/bindings/g...
File mojo/public/tools/bindings/generators/mojom_python_generator.py (right):

https://codereview.chromium.org/548343005/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_python_generator.py:40: # int64
integers are not handled by array.array
Hm. That's a bit of an issue, as many CrOS platforms are 64 bit, and integers
are that wide by default. Is there a way to work around this?

[qsr, 2014-09-09 14:30:20]

https://codereview.chromium.org/548343005/diff/1/mojo/public/tools/bindings/g...
File mojo/public/tools/bindings/generators/mojom_python_generator.py (right):

https://codereview.chromium.org/548343005/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_python_generator.py:40: # int64
integers are not handled by array.array
On 2014/09/09 14:20:26, Chris Masone wrote:
> Hm. That's a bit of an issue, as many CrOS platforms are 64 bit, and integers
> are that wide by default. Is there a way to work around this?

 Hum... Not sure to understand why this is an issue. That would only be used to
efficiently handle array of 64 bytes integer in generated struct. This is quite
a rare type in the mojom files anyway, so the fact that we use a python list to
represent those and encode those instead of a array.array is not that much of an
issue. It would be great to have a closer to native representation for those,
but I don't think the performance hit is such a problem given that I do not
expect those to be used a lot. For example, right now in chromium:

git grep int64\\\[ -- \*.mojom | wc -l
0

[sdefresne, 2014-09-10 08:40:00]

lgtm

https://codereview.chromium.org/548343005/diff/1/mojo/public/python/mojo/bind...
File mojo/public/python/mojo/bindings/descriptor.py (right):

https://codereview.chromium.org/548343005/diff/1/mojo/public/python/mojo/bind...
mojo/public/python/mojo/bindings/descriptor.py:69: (value, self._min_value,
self._max_value))
nit: indent

https://codereview.chromium.org/548343005/diff/1/mojo/public/tools/bindings/g...
File mojo/public/tools/bindings/generators/mojom_python_generator.py (right):

https://codereview.chromium.org/548343005/diff/1/mojo/public/tools/bindings/g...
mojo/public/tools/bindings/generators/mojom_python_generator.py:40: # int64
integers are not handled by array.array
On 2014/09/09 14:30:20, qsr wrote:
> On 2014/09/09 14:20:26, Chris Masone wrote:
> > Hm. That's a bit of an issue, as many CrOS platforms are 64 bit, and
integers
> > are that wide by default. Is there a way to work around this?
> 
>  Hum... Not sure to understand why this is an issue. That would only be used
to
> efficiently handle array of 64 bytes integer in generated struct. This is
quite
> a rare type in the mojom files anyway, so the fact that we use a python list
to
> represent those and encode those instead of a array.array is not that much of
an
> issue. It would be great to have a closer to native representation for those,
> but I don't think the performance hit is such a problem given that I do not
> expect those to be used a lot. For example, right now in chromium:
> 
> git grep int64\\\[ -- \*.mojom | wc -l
> 0

Maybe expand the comment to say that int64/uint64 array are supported but
storage is not optimized (ie. they are plain python list, not array.array).

[qsr, 2014-09-10 09:23:38]

https://chromiumcodereview.appspot.com/548343005/diff/1/mojo/public/python/mo...
File mojo/public/python/mojo/bindings/descriptor.py (right):

https://chromiumcodereview.appspot.com/548343005/diff/1/mojo/public/python/mo...
mojo/public/python/mojo/bindings/descriptor.py:69: (value, self._min_value,
self._max_value))
On 2014/09/10 08:40:00, sdefresne wrote:
> nit: indent

Done.

https://chromiumcodereview.appspot.com/548343005/diff/1/mojo/public/tools/bin...
File mojo/public/tools/bindings/generators/mojom_python_generator.py (right):

https://chromiumcodereview.appspot.com/548343005/diff/1/mojo/public/tools/bin...
mojo/public/tools/bindings/generators/mojom_python_generator.py:40: # int64
integers are not handled by array.array
On 2014/09/10 08:40:00, sdefresne wrote:
> On 2014/09/09 14:30:20, qsr wrote:
> > On 2014/09/09 14:20:26, Chris Masone wrote:
> > > Hm. That's a bit of an issue, as many CrOS platforms are 64 bit, and
> integers
> > > are that wide by default. Is there a way to work around this?
> > 
> >  Hum... Not sure to understand why this is an issue. That would only be used
> to
> > efficiently handle array of 64 bytes integer in generated struct. This is
> quite
> > a rare type in the mojom files anyway, so the fact that we use a python list
> to
> > represent those and encode those instead of a array.array is not that much
of
> an
> > issue. It would be great to have a closer to native representation for
those,
> > but I don't think the performance hit is such a problem given that I do not
> > expect those to be used a lot. For example, right now in chromium:
> > 
> > git grep int64\\\[ -- \*.mojom | wc -l
> > 0
> 
> Maybe expand the comment to say that int64/uint64 array are supported but
> storage is not optimized (ie. they are plain python list, not array.array).

Done.

[qsr, 2014-09-10 15:52:29]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-09-10 15:52:55]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/qsr@chromium.org/548343005/20001

[commit-bot: I haz the power, 2014-09-10 17:15:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-10 17:15:20]

Try jobs failed on following builders:
  android_aosp on tryserver.chromium.linux (None)

[qsr, 2014-09-11 07:56:07]

The CQ bit was checked by qsr@chromium.org

[commit-bot: I haz the power, 2014-09-11 08:01:30]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patchset/548343005/20001

[commit-bot: I haz the power, 2014-09-11 08:03:41]

Committed patchset #2 (id:20001) as 89831212732d7e2164f9db52c160108bb80056f1

[commit-bot: I haz the power, 2014-09-11 08:19:26]

Patchset 2 (id:??) landed as
https://crrev.com/1db711fe8d18883afe49a57dbd32aa7688de4206
Cr-Commit-Position: refs/heads/master@{#294354}