closure: consider <include>d files when tracking compilation progress.

closure: consider <include>d files when tracking compilation progress.

R=vitalyp@chromium.org,tbreisacher@chromium.org
BUG=407385
NOTRY=true

Committed: https://crrev.com/7563b7e3a58488b6ba4ed812f5f131a991cb1bf3
Cr-Commit-Position: refs/heads/master@{#293836}

[Dan Beam, 2014-09-06 01:12:55]

before:

compiled: 27 files, 8057 lines
need: 770 files, 216059 lines
3.73% done with the code we need to compile
want: 2723 files, 607851 lines
1.33% done with the code we want to compile


after:

compiled: 31 files, 8491 lines
need: 817 files, 233576 lines
3.64% done with the code we need to compile
want: 2799 files, 634297 lines
1.34% done with the code we want to compile


increase:

compiled: +4 files, +434 lines
need: +47 files, +17517 lines
want: +76 files, +26446 lines

[Dan Beam, 2014-09-06 01:19:12]

forgot the most important stats!

-0.09% done w/files we need to compile :(
+0.01% done w/files we want to compile :)

[Vitaly Pavlenko, 2014-09-06 01:25:25]

lgtm

[Dan Beam, 2014-09-08 19:18:24]

ping tbreisacher@

[Tyler Breisacher (Chromium), 2014-09-08 19:49:31]

lgtm

[Dan Beam, 2014-09-09 01:51:13]

The CQ bit was checked by dbeam@chromium.org

[commit-bot: I haz the power, 2014-09-09 01:53:28]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/dbeam@chromium.org/547853002/20001

[commit-bot: I haz the power, 2014-09-09 01:57:26]

Committed patchset #2 (id:20001) as 702ea972b540d0f3cd952bc470d9bd849dd046a3

[commit-bot: I haz the power, 2014-09-10 03:49:48]

Patchset 2 (id:??) landed as
https://crrev.com/7563b7e3a58488b6ba4ed812f5f131a991cb1bf3
Cr-Commit-Position: refs/heads/master@{#293836}

[Vitaly Pavlenko, 2014-09-16 01:11:16]

https://chromiumcodereview.appspot.com/547853002/diff/20001/third_party/closu...
File third_party/closure_compiler/tools/compile_coverage.py (right):

https://chromiumcodereview.appspot.com/547853002/diff/20001/third_party/closu...
third_party/closure_compiler/tools/compile_coverage.py:90:
compiled.update([os.path.abspath(d) for d in rel_depends])
Maybe
compiled.update([file for d in rel_depends for file in
processor.Processor(os.path.abspath(d)).included_files])
?

[Dan Beam, 2014-09-16 01:13:44]

https://chromiumcodereview.appspot.com/547853002/diff/20001/third_party/closu...
File third_party/closure_compiler/tools/compile_coverage.py (right):

https://chromiumcodereview.appspot.com/547853002/diff/20001/third_party/closu...
third_party/closure_compiler/tools/compile_coverage.py:90:
compiled.update([os.path.abspath(d) for d in rel_depends])
On 2014/09/16 01:11:16, Vitaly Pavlenko wrote:
> Maybe
> compiled.update([file for d in rel_depends for file in
> processor.Processor(os.path.abspath(d)).included_files])
> ?

this probably needs to recurse, though, no?

[Dan Beam, 2014-09-16 01:14:14]

https://chromiumcodereview.appspot.com/547853002/diff/20001/third_party/closu...
File third_party/closure_compiler/tools/compile_coverage.py (right):

https://chromiumcodereview.appspot.com/547853002/diff/20001/third_party/closu...
third_party/closure_compiler/tools/compile_coverage.py:90:
compiled.update([os.path.abspath(d) for d in rel_depends])
On 2014/09/16 01:13:43, Dan Beam wrote:
> On 2014/09/16 01:11:16, Vitaly Pavlenko wrote:
> > Maybe
> > compiled.update([file for d in rel_depends for file in
> > processor.Processor(os.path.abspath(d)).included_files])
> > ?
> 
> this probably needs to recurse, though, no?

oh, nvm, it already should... yeah that'd probably work