Remove the --event-page-idle-time and --event-page-suspending-time switches.

Remove the --event-page-idle-time and --event-page-suspending-time switches.

They were used only in tests, so change those tests to set a global state instead.

Committed: https://crrev.com/a9bf5603855c812d3987e16e9e7d5835663f5fc5
Cr-Commit-Position: refs/heads/master@{#295642}

[Yoyo Zhou, 2014-09-05 21:32:12]

yoz@chromium.org changed reviewers:
+ rdevlin.cronin@chromium.org, tapted@chromium.org

[Yoyo Zhou, 2014-09-05 21:32:12]

Devlin, please review
Trent, please OWNERS review for apps

[Devlin, 2014-09-05 22:06:08]

LGTM, modulo a few nits.

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/apps/e...
File chrome/browser/apps/ephemeral_app_launcher_browsertest.cc (right):

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/apps/e...
chrome/browser/apps/ephemeral_app_launcher_browsertest.cc:201:
extensions::ProcessManager::SetEventPageIdleTimeForTesting(1);
include?

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/extens...
File chrome/browser/extensions/app_background_page_apitest.cc (right):

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/extens...
chrome/browser/extensions/app_background_page_apitest.cc:136:
extensions::ProcessManager::SetEventPageIdleTimeForTesting(100);
include?

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/extens...
File chrome/browser/extensions/lazy_background_page_apitest.cc (right):

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/extens...
chrome/browser/extensions/lazy_background_page_apitest.cc:88:
extensions::ProcessManager::SetEventPageIdleTimeForTesting(1);
here too

[tapted, 2014-09-08 00:20:32]

Perhaps worth mentioning in the CL description that the timeout in some tests is
being reduced from 1s to 1ms. I think that's a good change, but It might change
some test behaviour. However, if it comes up, I think it would be nicer for
tests that need a longer timeout to increase it themselves.

otherwise c/b/apps lgtm

[Yoyo Zhou, 2014-09-08 16:19:10]

Good suggestion - I noted that test delay times have changed in the CL
description.

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/apps/e...
File chrome/browser/apps/ephemeral_app_launcher_browsertest.cc (right):

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/apps/e...
chrome/browser/apps/ephemeral_app_launcher_browsertest.cc:201:
extensions::ProcessManager::SetEventPageIdleTimeForTesting(1);
On 2014/09/05 22:06:07, Devlin wrote:
> include?

Done.

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/extens...
File chrome/browser/extensions/app_background_page_apitest.cc (right):

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/extens...
chrome/browser/extensions/app_background_page_apitest.cc:136:
extensions::ProcessManager::SetEventPageIdleTimeForTesting(100);
On 2014/09/05 22:06:07, Devlin wrote:
> include?

Done.

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/extens...
File chrome/browser/extensions/lazy_background_page_apitest.cc (right):

https://chromiumcodereview.appspot.com/547003002/diff/1/chrome/browser/extens...
chrome/browser/extensions/lazy_background_page_apitest.cc:88:
extensions::ProcessManager::SetEventPageIdleTimeForTesting(1);
On 2014/09/05 22:06:08, Devlin wrote:
> here too

Done.

[Yoyo Zhou, 2014-09-08 16:19:52]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-09-08 16:30:20]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/547003002/20001

[commit-bot: I haz the power, 2014-09-08 16:48:30]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-08 16:48:31]

Try jobs failed on following builders:
  ios_rel_device on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device/bu...)
  ios_rel_device_ninja on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/ios_rel_device_ni...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)

[Yoyo Zhou, 2014-09-08 18:54:20]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-09-08 18:55:33]

CQ is trying da patch. Follow status at
 https://chromium-status.appspot.com/cq/yoz@chromium.org/547003002/40001

[commit-bot: I haz the power, 2014-09-08 20:52:18]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-08 20:52:19]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yoyo Zhou, 2014-09-18 17:44:49]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-09-18 17:46:55]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/547003002/40001

[commit-bot: I haz the power, 2014-09-18 17:52:07]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 17:52:09]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  mac_chromium_rel_swarming on tryserver.chromium.mac
(http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)
  win_chromium_compile_dbg on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_comp...)
  win_chromium_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_rel_...)
  win_chromium_x64_rel_swarming on tryserver.chromium.win
(http://build.chromium.org/p/tryserver.chromium.win/builders/win_chromium_x64_...)

[Yoyo Zhou, 2014-09-18 22:15:31]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-09-18 22:17:02]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/547003002/60001

[commit-bot: I haz the power, 2014-09-18 23:33:01]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2014-09-18 23:33:02]

Try jobs failed on following builders:
  linux_chromium_chromeos_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)
  linux_chromium_rel_swarming on tryserver.chromium.linux
(http://build.chromium.org/p/tryserver.chromium.linux/builders/linux_chromium_...)

[Yoyo Zhou, 2014-09-19 01:00:59]

I put back 1000ms, since it appears that 1ms timeouts caused some of the tests
to fail; presumably they weren't properly waiting for the last message they
needed from the renderer. Since I'd rather not fix all of them now, I've just
left the original timeouts.

[Yoyo Zhou, 2014-09-19 01:01:07]

The CQ bit was checked by yoz@chromium.org

[commit-bot: I haz the power, 2014-09-19 01:03:06]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/547003002/80001

[commit-bot: I haz the power, 2014-09-19 02:03:40]

Committed patchset #5 (id:80001) as b504b81b2fa2760569ee883f89c486c0487a0c8d

[commit-bot: I haz the power, 2014-09-19 02:04:11]

Patchset 5 (id:??) landed as
https://crrev.com/a9bf5603855c812d3987e16e9e7d5835663f5fc5
Cr-Commit-Position: refs/heads/master@{#295642}