Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(828)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 545363002: Set the javac target and source to 1.7 (Closed)

Created:
6 years, 3 months ago by aurimas (slooooooooow)
Modified:
6 years, 3 months ago
Reviewers:
cjhopman, Yaron
CC:
chromium-reviews, klundberg+watch_chromium.org, erikwright+watch_chromium.org, yfriedman+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Project:
chromium
Visibility:
Public.

Description

Set the javac target and source to 1.7 BUG=336589 TBR=yfriedman@chromium.org Committed: https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b Cr-Commit-Position: refs/heads/master@{#295162}

Patch Set 1 #

Patch Set 2 : Rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+4 lines, -2 lines) Patch
M base/android/java/src/org/chromium/base/CollectionUtil.java View 1 chunk +2 lines, -0 lines 0 comments Download
M build/android/gyp/javac.py View 1 1 chunk +2 lines, -2 lines 0 comments Download

Messages

Total messages: 18 (7 generated)
aurimas (slooooooooow)
PTAL.
6 years, 3 months ago (2014-09-05 21:01:31 UTC) #2
cjhopman
lgtm
6 years, 3 months ago (2014-09-05 21:03:21 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/545363002/1
6 years, 3 months ago (2014-09-05 21:46:22 UTC) #5
commit-bot: I haz the power
Try jobs failed on following builders: android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/12899)
6 years, 3 months ago (2014-09-05 22:01:10 UTC) #7
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/545363002/1
6 years, 3 months ago (2014-09-09 20:14:20 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/aurimas@chromium.org/545363002/20001
6 years, 3 months ago (2014-09-09 20:58:19 UTC) #11
commit-bot: I haz the power
Try jobs failed on following builders: android_arm64_dbg_recipe on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_arm64_dbg_recipe/builds/3398) android_chromium_gn_compile_rel on tryserver.chromium.linux (http://build.chromium.org/p/tryserver.chromium.linux/builders/android_chromium_gn_compile_rel/builds/13802) android_clang_dbg_recipe ...
6 years, 3 months ago (2014-09-09 21:33:01 UTC) #13
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patchset/545363002/20001
6 years, 3 months ago (2014-09-16 22:07:51 UTC) #15
commit-bot: I haz the power
Committed patchset #2 (id:20001) as 2298901206346ff2e7564e86979b63a1b5a5ce78
6 years, 3 months ago (2014-09-16 22:38:00 UTC) #16
commit-bot: I haz the power
Patchset 2 (id:??) landed as https://crrev.com/165c0f17fe5760a3f346940d4fb2574d62cfe53b Cr-Commit-Position: refs/heads/master@{#295162}
6 years, 3 months ago (2014-09-16 22:38:41 UTC) #17
aurimas (slooooooooow)
6 years, 3 months ago (2014-09-16 22:47:25 UTC) #18
Message was sent while issue was closed. 
A revert of this CL (patchset #2 id:20001) has been created in
https://chromiumcodereview.appspot.com/579543003/ by aurimas@chromium.org.

The reason for reverting is: Not all bots have Java 7 yet :(.

Powered by Google App Engine
This is Rietveld 408576698