chrome/browser/resources/history/history.js - Issue 545303003: Small fix in chrome://history: mark checkbox as HTMLInputElement

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/resources/history/history.js

Issue 545303003: Small fix in chrome://history: mark checkbox as HTMLInputElement (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: chrome/browser/resources/history/history.js

diff --git a/chrome/browser/resources/history/history.js b/chrome/browser/resources/history/history.js

index f71c4992d985dfac0d05218b1ab03232550e3d8a..9dcc41da5ab36bc0510539ddb4f178f77fe11862 100644

--- a/chrome/browser/resources/history/history.js

+++ b/chrome/browser/resources/history/history.js

@@ -2180,7 +2180,8 @@ function entryBoxClick(event) {

return;

}

- var checkbox = $(event.currentTarget.getAttribute('for'));

+ var checkbox = /** @type {!HTMLInputElement} */(

Dan Beam 2014/09/05 21:28:46 why not assertInstanceOf?

Vitaly Pavlenko 2014/09/05 23:42:13 Done.

+ $(event.currentTarget.getAttribute('for')));

checkbox.checked = !checkbox.checked;

handleCheckboxStateChange(checkbox, event.shiftKey);

// We don't want to focus on the checkbox.

« no previous file with comments | « no previous file | no next file » | no next file with comments »