Small fix in chrome://history: mark checkbox as HTMLInputElement

chrome/browser/resources/history/history.js

 // Copyright (c) 2012 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 <include src="../uber/uber_utils.js">
 <include src="history_focus_manager.js">
 
 ///////////////////////////////////////////////////////////////////////////////
 // Globals:
 /** @const */ var RESULTS_PER_PAGE = 150;
@@ skipping 2162 matching lines @@
   var element = event.target;
   // Do nothing if the event happened in an interactive element.
   for (; element != event.currentTarget; element = element.parentNode) {
     switch (element.tagName) {
       case 'A':
       case 'BUTTON':
       case 'INPUT':
         return;
     }
   }
-  var checkbox = $(event.currentTarget.getAttribute('for'));
+  var checkbox = /** @type {!HTMLInputElement} */(

[Dan Beam, 2014/09/05 21:28:46]

why not assertInstanceOf?

[Vitaly Pavlenko, 2014/09/05 23:42:13]

Done.

+      $(event.currentTarget.getAttribute('for')));
   checkbox.checked = !checkbox.checked;
   handleCheckboxStateChange(checkbox, event.shiftKey);
   // We don't want to focus on the checkbox.
   event.preventDefault();
 }
 
 /**
  * Called when an individual history entry has been removed from the page.
  * This will only be called when all the elements affected by the deletion
  * have been removed from the DOM and the animations have completed.
@@ skipping 79 matching lines @@
     historyView.reload();
 }
 
 // Add handlers to HTML elements.
 document.addEventListener('DOMContentLoaded', load);
 
 // This event lets us enable and disable menu items before the menu is shown.
 document.addEventListener('canExecute', function(e) {
   e.canExecute = true;
 });