Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(64)

Issue 545303003: Small fix in chrome://history: mark checkbox as HTMLInputElement (Closed)

Created:
6 years, 3 months ago by Vitaly Pavlenko
Modified:
6 years, 3 months ago
Reviewers:
Dan Beam
CC:
chromium-reviews, Patrick Dubroy, pam+watch_chromium.org, arv+watch_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@true_master
Project:
chromium
Visibility:
Public.

Description

Small fix in chrome://history: mark checkbox as HTMLInputElement R=dbeam@chromium.org BUG=393873 TEST=GYP_GENERATORS=ninja gyp --depth . third_party/closure_compiler/compiled_resources.gyp && ninja -C out/Default Committed: https://crrev.com/87a3ebac6b26918b151151efed3311d0ddc20d73 Cr-Commit-Position: refs/heads/master@{#293627}

Patch Set 1 #

Total comments: 2

Patch Set 2 : switched to assertInstanceof #

Unified diffs Side-by-side diffs Delta from patch set Stats (+2 lines, -1 line) Patch
M chrome/browser/resources/history/history.js View 1 1 chunk +2 lines, -1 line 0 comments Download

Messages

Total messages: 12 (3 generated)
Vitaly Pavlenko
6 years, 3 months ago (2014-09-05 19:50:46 UTC) #1
Dan Beam
https://chromiumcodereview.appspot.com/545303003/diff/1/chrome/browser/resources/history/history.js File chrome/browser/resources/history/history.js (right): https://chromiumcodereview.appspot.com/545303003/diff/1/chrome/browser/resources/history/history.js#newcode2183 chrome/browser/resources/history/history.js:2183: var checkbox = /** @type {!HTMLInputElement} */( why not ...
6 years, 3 months ago (2014-09-05 21:28:46 UTC) #2
Vitaly Pavlenko
https://chromiumcodereview.appspot.com/545303003/diff/1/chrome/browser/resources/history/history.js File chrome/browser/resources/history/history.js (right): https://chromiumcodereview.appspot.com/545303003/diff/1/chrome/browser/resources/history/history.js#newcode2183 chrome/browser/resources/history/history.js:2183: var checkbox = /** @type {!HTMLInputElement} */( On 2014/09/05 ...
6 years, 3 months ago (2014-09-05 23:42:13 UTC) #3
Dan Beam
lgtm
6 years, 3 months ago (2014-09-06 00:16:20 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/545303003/20001
6 years, 3 months ago (2014-09-06 00:23:03 UTC) #6
commit-bot: I haz the power
Exceeded time limit waiting for builds to trigger.
6 years, 3 months ago (2014-09-06 06:32:16 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/vitalyp@chromium.org/545303003/20001
6 years, 3 months ago (2014-09-06 18:45:14 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001) as aa25ecaa57a1550c4f36308c9122d59a98588a54
6 years, 3 months ago (2014-09-06 18:59:26 UTC) #11
commit-bot: I haz the power
6 years, 3 months ago (2014-09-10 03:43:02 UTC) #12
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/87a3ebac6b26918b151151efed3311d0ddc20d73
Cr-Commit-Position: refs/heads/master@{#293627}

Powered by Google App Engine
This is Rietveld 408576698