Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1381)

Unified Diff: ui/webui/resources/js/cr/ui/splitter.js

Issue 543863002: Typecheck chrome://bookmarks using Closure Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master
Patch Set: rebase Created 6 years, 3 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: ui/webui/resources/js/cr/ui/splitter.js
diff --git a/ui/webui/resources/js/cr/ui/splitter.js b/ui/webui/resources/js/cr/ui/splitter.js
index c7b18ae4c9196e4794724c1130118f6d7964db15..2c1799e4f2216ce4ef0812c2d6f2b5e7e9929296 100644
--- a/ui/webui/resources/js/cr/ui/splitter.js
+++ b/ui/webui/resources/js/cr/ui/splitter.js
@@ -38,7 +38,7 @@ cr.define('cr.ui', function() {
* not take the page zoom into account so it returns the physical pixels
* instead of the logical pixel size.
* @param {!Document} doc The document to get the page zoom factor for.
- * @param {number} The zoom factor of the document.
+ * @return {number} The zoom factor of the document.
*/
function getZoomFactor(doc) {
var dummyElement = doc.createElement('div');
@@ -130,10 +130,11 @@ cr.define('cr.ui', function() {
/**
* Handles the mousedown event which starts the dragging of the splitter.
- * @param {!MouseEvent} e The mouse event.
+ * @param {!Event} e The mouse event.
* @private
*/
handleMouseDown_: function(e) {
+ e = /** @type {!MouseEvent} */(e);
this.startDrag(e.clientX, false);
// Default action is to start selection and to move focus.
e.preventDefault();
@@ -141,10 +142,11 @@ cr.define('cr.ui', function() {
/**
* Handles the touchstart event which starts the dragging of the splitter.
- * @param {!TouchEvent} e The touch event.
+ * @param {!Event} e The touch event.
* @private
*/
handleTouchStart_: function(e) {
+ e = /** @type {!TouchEvent} */(e);
if (e.touches.length == 1) {
this.startDrag(e.touches[0].clientX, true);
e.preventDefault();
@@ -209,7 +211,7 @@ cr.define('cr.ui', function() {
/**
* Handles splitter moves. Updates width of the element being resized.
- * @param {number} changeX The change of splitter horizontal position.
+ * @param {number} deltaX The change of splitter horizontal position.
* @protected
*/
handleSplitterDragMove: function(deltaX) {

Powered by Google App Engine
This is Rietveld 408576698