third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java - Issue 543863002: Typecheck chrome://bookmarks using Closure Compiler

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java

Issue 543863002: Typecheck chrome://bookmarks using Closure Compiler (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@true_master

Patch Set: remove runner.jar from CL Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« chrome/browser/resources/bookmark_manager/js/main.js ('K') | « third_party/closure_compiler/externs/system_private.js ('k') | third_party/closure_compiler/runner/test/com/google/javascript/jscomp/ChromePassTest.java » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java

diff --git a/third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java b/third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java

index be8da2eaa45fe5f55389941158795b06da76a36e..7689b26b16af7b8c72da570063b7d59474a16f14 100644

--- a/third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java

+++ b/third_party/closure_compiler/runner/src/com/google/javascript/jscomp/ChromePass.java

@@ -314,11 +314,11 @@ public class ChromePass extends AbstractPostOrderCallback implements CompilerPas

for (Node keyNode : objectLit.children()) {

String key = keyNode.getString();

- // TODO(vitalyp): Can dict value be other than a simple NAME? What if NAME doesn't

- // refer to a function/constructor?

- String value = keyNode.getFirstChild().getString();

- res.put(value, key);

+ Node valueNode = keyNode.getFirstChild();

+ if (valueNode.isName()) {

+ String value = keyNode.getFirstChild().getString();

+ res.put(value, key);

+ }

}

return res;