net/tools/dump_cache/simple_cache_dumper.cc - Issue 542733002: Remove void** from disk_cache interface.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: net/tools/dump_cache/simple_cache_dumper.cc

Issue 542733002: Remove void** from disk_cache interface. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: narrowest, remove unused function Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: net/tools/dump_cache/simple_cache_dumper.cc

diff --git a/net/tools/dump_cache/simple_cache_dumper.cc b/net/tools/dump_cache/simple_cache_dumper.cc

index 56162ca3e10905e2e327ea3a807f20519047d947..094eac681bdcf31f3a07824d829766932344a5eb 100644

--- a/net/tools/dump_cache/simple_cache_dumper.cc

+++ b/net/tools/dump_cache/simple_cache_dumper.cc

@@ -26,7 +26,6 @@ SimpleCacheDumper::SimpleCacheDumper(base::FilePath input_path,

output_path_(output_path),

writer_(new DiskDumper(output_path)),

cache_thread_(new base::Thread("CacheThead")),

- iter_(NULL),

src_entry_(NULL),

dst_entry_(NULL),

io_callback_(base::Bind(&SimpleCacheDumper::OnIOComplete,

@@ -156,7 +155,7 @@ int SimpleCacheDumper::DoOpenEntry() {

int SimpleCacheDumper::DoOpenEntryComplete(int rv) {

// ERR_FAILED indicates iteration finished.

if (rv == ERR_FAILED) {

- cache_->EndEnumeration(&iter_);

+ iter_.reset();

return OK;

}