extensions/shell/app_shell.gyp - Issue 529293003: Extract ResultCatcher from ExtensionApiTest. Use it in ShellApiTest.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: extensions/shell/app_shell.gyp

Issue 529293003: Extract ResultCatcher from ExtensionApiTest. Use it in ShellApiTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: deprecate Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: extensions/shell/app_shell.gyp

diff --git a/extensions/shell/app_shell.gyp b/extensions/shell/app_shell.gyp

index ca52ecede70e41ba66b7cda192c99196334596f1..15a2f339008c3c1118c06bb172bc10aa9d9594f8 100644

--- a/extensions/shell/app_shell.gyp

+++ b/extensions/shell/app_shell.gyp

@@ -181,8 +181,10 @@

'../browser/api/sockets_tcp/sockets_tcp_apitest.cc',

'../browser/api/sockets_udp/sockets_udp_apitest.cc',

'browser/shell_browsertest.cc',

- 'test/shell_test.h',

+ 'test/shell_apitest.cc',

+ 'test/shell_apitest.h',

'test/shell_test.cc',

+ 'test/shell_test.h',

'test/shell_test_launcher_delegate.cc',

'test/shell_test_launcher_delegate.h',

'test/shell_tests_main.cc',

« no previous file with comments | « extensions/extensions.gyp ('k') | extensions/shell/browser/shell_browsertest.cc » ('j') | no next file with comments »