extensions/test/DEPS - Issue 529293003: Extract ResultCatcher from ExtensionApiTest. Use it in ShellApiTest.

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: extensions/test/DEPS

Issue 529293003: Extract ResultCatcher from ExtensionApiTest. Use it in ShellApiTest. (Closed) Base URL: https://chromium.googlesource.com/chromium/src@master

Patch Set: Created 6 years, 3 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« extensions/shell/test/shell_apitest.cc ('K') | « extensions/shell/test/shell_test.cc ('k') | extensions/test/data/api_test/dns/api/background.js » ('j') | extensions/test/data/api_test/dns/api/background.js » ('J')
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

OLD	NEW
1 include_rules = [	1 include_rules = [

	2 "+content/public/browser",
	Yoyo Zhou 2014/09/03 02:10:16 I'm not sure whether it's better to put things lik I'm not sure whether it's better to put things like result_catcher in extensions/browser or extensions/test. I think I would prefer extensions/test, since among other things it's not immediately obvious from the name that it's test-related. On the other hand, it's easier to keep the dependencies in line if it's in extensions/browser. Thoughts? James Cook 2014/09/03 18:08:41 I think it's better to keep these in extensions/te Show quoted text On 2014/09/03 02:10:16, Yoyo Zhou wrote: > I'm not sure whether it's better to put things like result_catcher in > extensions/browser or extensions/test. I think I would prefer extensions/test, > since among other things it's not immediately obvious from the name that it's > test-related. On the other hand, it's easier to keep the dependencies in line if > it's in extensions/browser. Thoughts? I think it's better to keep these in extensions/test. I would probably just do "+content/public", which is what is done in chrome/test/DEPS. Yoyo Zhou 2014/09/04 21:57:42 Done. Show quoted text On 2014/09/03 18:08:41, James Cook wrote: > On 2014/09/03 02:10:16, Yoyo Zhou wrote: > > I'm not sure whether it's better to put things like result_catcher in > > extensions/browser or extensions/test. I think I would prefer extensions/test, > > since among other things it's not immediately obvious from the name that it's > > test-related. On the other hand, it's easier to keep the dependencies in line > if > > it's in extensions/browser. Thoughts? > > I think it's better to keep these in extensions/test. I would probably just do > "+content/public", which is what is done in chrome/test/DEPS. Done.
2 "+mojo/embedder",	3 "+mojo/embedder",

3 ]	4 ]

OLD	NEW