chrome/browser/custom_home_pages_table_model.cc - Issue 52823006: Small crash fix for set pages dialog drag'n'drop issue.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/custom_home_pages_table_model.cc

Issue 52823006: Small crash fix for set pages dialog drag'n'drop issue. (Closed) Base URL: svn://svn.chromium.org/chrome/trunk/src

Patch Set: Created 7 years, 1 month ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/custom_home_pages_table_model.cc

diff --git a/chrome/browser/custom_home_pages_table_model.cc b/chrome/browser/custom_home_pages_table_model.cc

index 24607174635a0eab19ed825f5d08dfc3e82986d2..c2cdfa196ad8305fa68b4b11631a6bb0731e1826 100644

--- a/chrome/browser/custom_home_pages_table_model.cc

+++ b/chrome/browser/custom_home_pages_table_model.cc

@@ -96,7 +96,7 @@ void CustomHomePagesTableModel::SetURLs(const std::vector<GURL>& urls) {

void CustomHomePagesTableModel::MoveURLs(int insert_before,

const std::vector<int>& index_list) {

- DCHECK(!index_list.empty());

+ if (index_list.empty()) return;

DCHECK(insert_before >= 0 && insert_before <= RowCount());

// The range of elements that needs to be reshuffled is [ |first|, |last| ).

« no previous file with comments | « no previous file | chrome/browser/ui/webui/options/options_browsertest.js » ('j') | no next file with comments »