mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java - Issue 522653004: mojo: Validate fixed size array for the mojo java bindings.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java

Issue 522653004: mojo: Validate fixed size array for the mojo java bindings. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 6 years, 4 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « no previous file | mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java » ('j') | mojo/public/java/bindings/src/org/chromium/mojo/bindings/Decoder.java » ('J')
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java

diff --git a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java

index d94796831b0e28de4c8995435671adbba586b5a1..32eb9bf3543cdc2ce44448cc12a33c5f20ce2cc5 100644

--- a/mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java

+++ b/mojo/public/java/bindings/src/org/chromium/mojo/bindings/BindingsHelper.java

@@ -29,6 +29,11 @@ public class BindingsHelper {

public static final int POINTER_SIZE = 8;

/**

+ * The value used for the expected length of a non-fixed size array.

+ */

+ public static final int UNDEFINED_ARRAY_LENTH = -1;

ppi 2014/08/29 15:23:45 s/LENTH/LENGTH, also I'd go for UNSPECIFIED ("spec

qsr 2014/08/29 16:24:11 Done.

+ /**

* Align |size| on {@link BindingsHelper#ALIGNMENT}.

public static int align(int size) {